Repository navigation
fix(rocprofiler-compute): Use pandas wheel on Python 3.14 - #13051
Merged
Merged
Conversation
- Pin pandas 2.3.3 on Python >= 3.14, the first release with cp314 wheels, so analyze dependencies install without a source build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The complementary version markers implement the intended dependency selection without identified blocking issues.
0 open findings
What changed in this PR
Updates rocprofiler-compute’s pandas dependency to use prebuilt wheels on Python 3.14, avoiding a pandas source build.
Changes:
- Pins pandas 2.3.3 for Python ≥ 3.14.
- Retains pandas 2.2.3 for older Python versions.
| File | Description |
|---|---|
| projects/rocprofiler-compute/requirements.txt | Adds Python-version-specific pandas pins and an explanatory comment. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
habajpai-amd
approved these changes
Oct 8, 2026
ggottipa-amd
approved these changes
Oct 8, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
anujshuk-amd
pushed a commit
that referenced
this pull request
Oct 12, 2026
## Motivation Install pandas from a prebuilt wheel on Python 3.14 so analyze dependencies no longer need a source build and a C/C++ compiler. ## Technical Details - Pin pandas 2.3.3 on Python >= 3.14 (first release with cp314 wheels); keep 2.2.3 below that. ## JIRA ID JIRA ID: ROCM-32373 ## Test Plan - [x] Install `requirements.txt` wheel-only (`--no-build`) into fresh Python 3.14 and 3.12 venvs. - [x] Run the analyze dependency check in both venvs. ## Test Result - [x] Python 3.14 gets pandas 2.3.3 and Python 3.12 gets pandas 2.2.3, both from wheels; dependency check passes. Works locally. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Install pandas from a prebuilt wheel on Python 3.14 so analyze dependencies no longer need a source build and a C/C++ compiler.
Technical Details
JIRA ID
JIRA ID: ROCM-32373
Test Plan
requirements.txtwheel-only (--no-build) into fresh Python 3.14 and 3.12 venvs.Test Result
Submission Checklist
🤖 Generated with Claude Code