Skip to content

feat(rocr): add signal handle hints and hsa_amd_signal_batch_create #12988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arvindcheru merged 1 commit into from
Oct 17, 2026
Merged

feat(rocr): add signal handle hints and hsa_amd_signal_batch_create #12988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions projects/rocprofiler-sdk/source/include/rocprofiler-sdk/cxx/enum_string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,10 @@ ROCPROFILER_ENUM_LABEL(ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_vmem_get_vmem_info
# if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x16
ROCPROFILER_ENUM_LABEL(ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_enable_high_precision_timestamps);
# endif
# if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x17
ROCPROFILER_ENUM_LABEL(ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_signal_batch_create);
ROCPROFILER_ENUM_LABEL(ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_signal_batch_destroy);
# endif
#endif

#if HSA_AMD_EXT_API_TABLE_MAJOR_VERSION == 0x01
Expand Down Expand Up @@ -500,6 +504,8 @@ static_assert(ROCPROFILER_HSA_AMD_EXT_API_ID_LAST == 93);
static_assert(ROCPROFILER_HSA_AMD_EXT_API_ID_LAST == 94);
# elif HSA_AMD_EXT_API_TABLE_STEP_VERSION == 0x16
static_assert(ROCPROFILER_HSA_AMD_EXT_API_ID_LAST == 95);
# elif HSA_AMD_EXT_API_TABLE_STEP_VERSION == 0x17
static_assert(ROCPROFILER_HSA_AMD_EXT_API_ID_LAST == 97);
# else
# if !defined(ROCPROFILER_UNSAFE_NO_VERSION_CHECK) && \
(defined(ROCPROFILER_CI) && ROCPROFILER_CI > 0)
Expand Down
4 changes: 4 additions & 0 deletions projects/rocprofiler-sdk/source/include/rocprofiler-sdk/hsa/amd_ext_api_id.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ typedef enum rocprofiler_hsa_amd_ext_api_id_t // NOLINT(performance-enum-size)
# if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x16
ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_enable_high_precision_timestamps,
# endif
# if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x17
ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_signal_batch_create,
ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_signal_batch_destroy,
# endif
#endif

ROCPROFILER_HSA_AMD_EXT_API_ID_LAST,
Expand Down
17 changes: 17 additions & 0 deletions projects/rocprofiler-sdk/source/include/rocprofiler-sdk/hsa/api_args.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,6 +1618,23 @@ typedef union rocprofiler_hsa_api_args_t
rocprofiler_hsa_api_no_args no_args;
} hsa_amd_enable_high_precision_timestamps;
# endif
# if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x17
struct
{
uint32_t count;
const hsa_signal_value_t* initial_values;
uint32_t num_consumers;
const hsa_agent_t* consumers;
uint64_t attributes;
hsa_amd_memory_pool_t pool;
hsa_amd_signal_batch_t* batch;
hsa_signal_t* signals;
} hsa_amd_signal_batch_create;
struct
{
hsa_amd_signal_batch_t batch;
} hsa_amd_signal_batch_destroy;
# endif
#endif
} rocprofiler_hsa_api_args_t;

Expand Down
6 changes: 6 additions & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/abi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ ROCP_SDK_ENFORCE_ABI_VERSIONING(::AmdExtTable, 94);
ROCP_SDK_ENFORCE_ABI_VERSIONING(::AmdExtTable, 95);
#elif HSA_AMD_EXT_API_TABLE_STEP_VERSION == 0x16
ROCP_SDK_ENFORCE_ABI_VERSIONING(::AmdExtTable, 96);
#elif HSA_AMD_EXT_API_TABLE_STEP_VERSION == 0x17
ROCP_SDK_ENFORCE_ABI_VERSIONING(::AmdExtTable, 98);
#else
INTERNAL_CI_ROCP_SDK_ENFORCE_ABI_VERSIONING(::AmdExtTable, 0);
#endif
Expand Down Expand Up @@ -374,6 +376,10 @@ ROCP_SDK_ENFORCE_ABI(::AmdExtTable, hsa_amd_vmem_get_vmem_info_fn, 94);
#if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x16
ROCP_SDK_ENFORCE_ABI(::AmdExtTable, hsa_amd_enable_high_precision_timestamps_fn, 95);
#endif
#if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x17
ROCP_SDK_ENFORCE_ABI(::AmdExtTable, hsa_amd_signal_batch_create_fn, 96);
ROCP_SDK_ENFORCE_ABI(::AmdExtTable, hsa_amd_signal_batch_destroy_fn, 97);
#endif

ROCP_SDK_ENFORCE_ABI(::ImageExtTable, hsa_ext_image_get_capability_fn, 1);
ROCP_SDK_ENFORCE_ABI(::ImageExtTable, hsa_ext_image_data_get_info_fn, 2);
Expand Down
19 changes: 19 additions & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/hsa.def.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,25 @@ HSA_API_INFO_DEFINITION_0(ROCPROFILER_HSA_TABLE_ID_AmdExt,
hsa_amd_enable_high_precision_timestamps,
hsa_amd_enable_high_precision_timestamps_fn)
# endif
# if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x17
HSA_API_INFO_DEFINITION_V(ROCPROFILER_HSA_TABLE_ID_AmdExt,
ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_signal_batch_create,
hsa_amd_signal_batch_create,
hsa_amd_signal_batch_create_fn,
count,
initial_values,
num_consumers,
consumers,
attributes,
pool,
batch,
signals)
HSA_API_INFO_DEFINITION_V(ROCPROFILER_HSA_TABLE_ID_AmdExt,
ROCPROFILER_HSA_AMD_EXT_API_ID_hsa_amd_signal_batch_destroy,
hsa_amd_signal_batch_destroy,
hsa_amd_signal_batch_destroy_fn,
batch)
# endif
# endif

#elif defined(ROCPROFILER_LIB_ROCPROFILER_HSA_ASYNC_COPY_CPP_IMPL) && \
Expand Down
7 changes: 7 additions & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,13 @@ struct formatter<hsa_amd_vmem_alloc_handle_t>
: rocprofiler::hsa::utils::handle_formatter<hsa_amd_vmem_alloc_handle_t>
{};

# if HSA_AMD_EXT_API_TABLE_STEP_VERSION >= 0x17
template <>
struct formatter<hsa_amd_signal_batch_t>
: rocprofiler::hsa::utils::handle_formatter<hsa_amd_signal_batch_t>
{};
# endif

template <>
struct formatter<hsa_access_permission_t>
{
Expand Down
8 changes: 8 additions & 0 deletions projects/rocr-runtime/rocrtst/config/platform_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ groups:
- rocrtstFunc.GL2_PersistingCache_NegativeInvalidSize
- rocrtstFunc.GL2_PersistingCache_NegativeCPUAgent

SignalBatch:
- rocrtstFunc.Signal_Batch_Host_Pool
- rocrtstFunc.Signal_Batch_Device_Pools
- rocrtstFunc.Signal_Batch_Async_Copy_Completion
- rocrtstFunc.Signal_Batch_Negative
- rocrtstFunc.Signal_Batch_Agent_Queries
- rocrtstFunc.Signal_Handle_Hints

Performance:
- rocrtstPerf.Memory_Async_Copy_On_Engine
- rocrtstPerf.ENQUEUE_LATENCY
Expand Down
Loading
Loading