Repository navigation
fix(rocprofiler-sdk): Add null signal for backwards compatibility rocr-runtime OOB error - #12957
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The sentinel preserves existing wait semantics while safely accommodating the older runtime behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a compatibility safeguard for older ROCr runtimes during completion-signal waits.
Changes:
- Appends null sentinel entries to the parallel wait arrays.
- Excludes the sentinel from the logical signal count.
| File | Description |
|---|---|
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/queue_interposition.cpp |
Adds trailing storage to guard older runtime out-of-bounds access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
6a4013e to
0cf0244
Compare
TheRock Submodule Bump ActivityNewest first
|
Motivation
Technical Details
Issue Tracking
Test Plan
Test Result
Submission Checklist