Skip to content

fix(rocprofiler-sdk): Add null signal for backwards compatibility rocr-runtime OOB error - #12957

Merged
jrmadsen merged 1 commit into
developfrom
users/itrowbri/backward-compatibility-queue-interposition
Oct 14, 2026
Merged

jrmadsen merged 1 commit into
developfrom
users/itrowbri/backward-compatibility-queue-interposition

Conversation

@itrowbri

@itrowbri itrowbri commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Issue Tracking

Test Plan

Test Result

Submission Checklist

Copilot AI balanced review requested due to automatic review settings October 6, 2026 20:24
@itrowbri
itrowbri requested review from a team as code owners October 6, 2026 20:24
@itrowbri itrowbri changed the title Add null signal for backwards compatibility for rocr-runtime OOB error fix(rocprofiler-sdk): Add null signal for backwards compatibility rocr-runtime OOB error Oct 6, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/queue_interposition.cpp; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The sentinel preserves existing wait semantics while safely accommodating the older runtime behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Adds a compatibility safeguard for older ROCr runtimes during completion-signal waits.

Changes:

  • Appends null sentinel entries to the parallel wait arrays.
  • Excludes the sentinel from the logical signal count.
File Description
projects/​rocprofiler-sdk/​source/​lib/​rocprofiler-sdk/​hsa/​queue_interposition.cpp Adds trailing storage to guard older runtime out-of-bounds access.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@itrowbri
itrowbri force-pushed the users/itrowbri/backward-compatibility-queue-interposition branch from 6a4013e to 0cf0244 Compare October 13, 2026 13:46
@jrmadsen
jrmadsen merged commit 93bd837 into develop Oct 14, 2026
129 of 133 checks passed
@jrmadsen
jrmadsen deleted the users/itrowbri/backward-compatibility-queue-interposition branch October 14, 2026 03:10
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants