Repository navigation
rocjitsu: bump test corpus for optimized CTS builds - #12932
Merged
Merged
Conversation
github-actions
Bot
added
the
github actions
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Both pins consistently select the verified merged corpus revision, with no blocking issues identified.
Review effort: Balanced
Findings: None
What changed in this PR
Updates rocjitsu’s HIP/DBT test corpus to pick up optimized CTS builds with assertions enabled and required integer instruction coverage preserved.
Changes:
- Sets both the manual-dispatch default and automatic checkout pin to
387502e864cce3f0490a967e9a185b4922a5e7de. - Updates the pin’s date comment.
| File | Description |
|---|---|
.github/workflows/rocjitsu-corpus-tests.yml |
Updates both corpus pins and the date comment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kuhar
approved these changes
Oct 6, 2026
Contributor
gfx1250 B0-to-A0 translation baselineWarning The PR result is not directly comparable to the latest develop baseline. Changed provenance:
Compared PR head |
Contributor
TheRock Submodule Bump ActivityNewest first
|
anujshuk-amd
pushed a commit
that referenced
this pull request
Oct 12, 2026
## Motivation Rocjitsu CI still pins a corpus revision that builds most CTS tests without optimization. Pick up ROCm/rocjitsu-test-corpus#53 so CI uses Release builds with assertions enabled while preserving required integer instruction coverage. ## Technical Details Bump the HIP/DBT corpus pin from `cc781dd88cabd1638d1beeb4539c521ccf27de60` to `387502e864cce3f0490a967e9a185b4922a5e7de` in both the automatic checkout fallback and the manual-dispatch default. Update the pin's date comment. The pinned revision includes the wave32 `mbcnt` and gfx1250 comparison optimization overrides and the strengthened `mbcnt_hi` coverage requirement. The bump also includes intervening corpus changes, including the newer gfx1250 ISA coverage and runtime CTS additions; see the [corpus commit range](ROCm/rocjitsu-test-corpus@cc781dd...387502e). Temporarily exclude all 37 gfx1250 CTS cases introduced by ROCm/rocjitsu-test-corpus#41 (22 integer cases) and ROCm/rocjitsu-test-corpus#42 (15 memory cases), including their coverage checks. The existing skip configuration applies to both the initial run and failed-test retries. Reason: These tests are really slow and haven't been verified for their usefulness. Someone needs to investigate these before they are enabled ## Issue Tracking ISSUE ID: ROCm/rocjitsu-test-corpus#53 ## Test Plan - Parse the workflow YAML and verify the dispatch default and automatic checkout pin both select the merged corpus revision. - Run the repository pre-commit checks on the changed workflow and `git diff --check`. - Exercise the updated pin through this PR's rocjitsu corpus workflow. ## Test Result Local YAML/pin validation, applicable pre-commit checks, and whitespace checks passed. A targeted pytest run confirms all 37 integer/memory cases are skipped before build or execution (37 skipped, 43 deselected). ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rocjitsu CI still pins a corpus revision that builds most CTS tests without optimization. Pick up ROCm/rocjitsu-test-corpus#53 so CI uses Release builds with assertions enabled while preserving required integer instruction coverage.
Technical Details
Bump the HIP/DBT corpus pin from
cc781dd88cabd1638d1beeb4539c521ccf27de60to387502e864cce3f0490a967e9a185b4922a5e7dein both the automatic checkout fallback and the manual-dispatch default. Update the pin's date comment.The pinned revision includes the wave32
mbcntand gfx1250 comparison optimization overrides and the strengthenedmbcnt_hicoverage requirement. The bump also includes intervening corpus changes, including the newer gfx1250 ISA coverage and runtime CTS additions; see the corpus commit range.Temporarily exclude all 37 gfx1250 CTS cases introduced by ROCm/rocjitsu-test-corpus#41 (22 integer cases) and ROCm/rocjitsu-test-corpus#42 (15 memory cases), including their coverage checks. The existing skip configuration applies to both the initial run and failed-test retries.
Reason: These tests are really slow and haven't been verified for their usefulness. Someone needs to investigate these before they are enabled
Issue Tracking
ISSUE ID: ROCm/rocjitsu-test-corpus#53
Test Plan
git diff --check.Test Result
Local YAML/pin validation, applicable pre-commit checks, and whitespace checks passed. A targeted pytest run confirms all 37 integer/memory cases are skipped before build or execution (37 skipped, 43 deselected).
Submission Checklist