Repository navigation
docs(hip): say that HRR capture ignores its output variable in privileged programs - #12903
andraghetti wants to merge 3 commits into
Conversation
… programs The HRR how-to gains one paragraph: on Linux, a program the kernel starts in secure-execution mode ignores HIP_HRR_CAPTURE_OUTPUT, records nothing and says why on standard error. The behaviour comes with #12252.
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The runtime prerequisite #12252 remains unmerged, so the documented behavior requires merge-order confirmation before approval.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Documents the Linux secure-execution restriction introduced by #12252 in HIP’s record-and-replay guide.
Changes:
- Adds a paragraph explaining that secure-execution programs ignore
HIP_HRR_CAPTURE_OUTPUT, disable capture, and report ignored requests.
| File | Description |
|---|---|
| projects/hip/docs/how-to/hip_record_replay.rst | Documents capture restrictions for secure-execution programs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
52ba608 to
1f1ebea
Compare
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
danielbolsson
left a comment
There was a problem hiding this comment.
Read the new paragraph against hip_capture.cpp (hrr_secure_exec via getauxval(AT_SECURE), stderr line only when capture was requested) and hip_capture_metadata.cpp; the wording matches the code.
|
Closing this: the same rule is already in the HRR docs since #12252, in the |

Motivation
#12252 makes HRR capture ignore
HIP_HRR_CAPTURE_OUTPUTin privileged processes. This adds that rule to the HIP how-to on record and replay. It is a separate pull request because this file needs a HIP docs review, and #12252 can then merge on the HRR review alone.Technical Details
projects/hip/docs/how-to/hip_record_replay.rst, after the note on what an archive contains.Issue Tracking
JIRA ID: AIRUNTIME-2828
Test Plan
Documentation only. The docs build in CI renders the page.
Test Result
Pending CI.
Submission Checklist