Skip to content

test(rccl): cover KernelCh profiling on the per-communicator profiler thread #12715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i-kosarev merged 14 commits into from
Oct 21, 2026
Merged

test(rccl): cover KernelCh profiling on the per-communicator profiler thread #12715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a5790b6
test(rccl): cover KernelCh profiling on the per-communicator profiler…
i-kosarev Oct 1, 2026
df11ec0
test(rccl): address review on the KernelCh profiler-thread tests
i-kosarev Oct 8, 2026
5fe1b1b
test(rccl): address the second review round on the KernelCh tests
i-kosarev Oct 8, 2026
0473744
test(rccl): create the fixture communicator without the success-only …
i-kosarev Oct 8, 2026
71fdf57
test(rccl): fail on a rejected recorder, abort on a non-blocking comm…
i-kosarev Oct 9, 2026
182e964
test(rccl): agree on buffer allocation and check every KernelCh callb…
i-kosarev Oct 9, 2026
1ef7c49
test(rccl): judge split thread ownership on every KernelCh callback
i-kosarev Oct 9, 2026
0c51d29
test(rccl): agree on graph, split and timer setup; reject mismatched …
i-kosarev Oct 13, 2026
ce206f6
test(rccl): flag a KernelCh stop state that arrives after stopEvent
i-kosarev Oct 13, 2026
5588f40
test(rccl): cover KernelPhase events from the symmetric kernels
i-kosarev Oct 13, 2026
3455ab1
test(rccl): make both symmetric window registrations on every rank
i-kosarev Oct 13, 2026
be9b210
test(rccl): skip the mixing test when the environment turns mixing of…
i-kosarev Oct 14, 2026
ecbab13
Merge remote-tracking branch 'origin/develop' into users/ilkosare/ker…
i-kosarev Oct 14, 2026
a45559b
test(rccl): agree on capture start; keep KernelCh off Coll/P2p threads
i-kosarev Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions projects/rccl/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,7 @@ if(BUILD_TESTS)
GrowMPITests.cpp
GinNcclTimeoutMPITests.cpp
InspectorPromP2pMPITests.cpp
ProfilerKernelChMPITests.cpp
SymmetricKernelMPITests.cpp
SymmetricWindowMPITests.cpp
DeviceApiMPITests.cpp
Expand Down Expand Up @@ -1070,6 +1071,24 @@ if(BUILD_TESTS)

list(APPEND RCCL_TEST_EXECUTABLES rccl-UnitTestsMPI)

# Recorder profiler plugin for ProfilerKernelChMPITests. Unlike
# rccl-test-profiler-stub it is a working profiler: it records what RCCL
# delivers so the test can check it. It builds against the standalone headers
# an external plugin ships with rather than RCCL's own, and it lands and
# installs beside the test binary, which is where the test looks for it.
add_library(rccl-test-profiler-kch-recorder SHARED plugin/profiler_kernelch_recorder.cpp)
target_include_directories(rccl-test-profiler-kch-recorder PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/../plugins/profiler/example/nccl
${CMAKE_CURRENT_SOURCE_DIR}/plugin)
set_target_properties(rccl-test-profiler-kch-recorder PROPERTIES
CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON)
add_dependencies(rccl-UnitTestsMPI rccl-test-profiler-kch-recorder)
target_compile_definitions(rccl-UnitTestsMPI PRIVATE
RCCL_TEST_KCH_RECORDER_NAME="$<TARGET_FILE_NAME:rccl-test-profiler-kch-recorder>")
install(TARGETS rccl-test-profiler-kch-recorder
LIBRARY DESTINATION ${CMAKE_INSTALL_BINDIR}
COMPONENT tests)

# Loadable GIN plugin for GinConnectLeakMPITest, built and installed beside the test binary.
add_library(rccl-test-gin-fault-plugin SHARED plugin/gin_fault_plugin.cpp)
target_include_directories(rccl-test-gin-fault-plugin PRIVATE ${RCCL_COMMON_INCLUDE_DIRS})
Expand Down
Loading
Loading