Repository navigation
Conversation
Recorder.RedOpRecordJson only sees what the JSON format strings print, so the raw rcclApiCall fields written in binary mode, and anything Destroy must not copy, are unchecked. Recorder.RedOpRecordBinary reads both records back from the binary dump and is registered next to RedOpRecordJson in every test_runner config.
![amd-argus[bot]](https://avatars.githubusercontent.com/in/4740020?s=60&v=4){kind=small}
Contributor
Author
|
@argus re-review |
pvallem
merged commit Oct 2, 2026
e8fdafb
into
users/pvallem/GIN_TESTS-combined-misc
48 of 49 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the JSON path of Recorder RedOp records is tested, so raw rcclApiCall fields written in binary mode can regress unseen.
Fix: read both RedOp records back from the binary dump and check each field; stacked on #12641.
JIRA ID: AICOMRCCL-2699