Repository navigation
Adding C Wrappers for alltoall and broadcast - #12668
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
amirsojoodi
reviewed
Oct 2, 2026
Remove wrappers that expose non-ctx symbols (e.g. rocshmem_int_alltoall_wave,
rocshmem_int_broadcast_wg) that have no corresponding public API declarations
in rocshmem_COLL.hpp. Only ctx versions exist for these in the public headers.
Removed wrappers:
- alltoall typed wave (rocshmem_TYPE_alltoall_wave)
- alltoall untyped mem (rocshmem_alltoallmem_wg/wave)
- broadcast typed wg (rocshmem_TYPE_broadcast_wg)
- broadcast typed wave (rocshmem_TYPE_broadcast_wave)
- broadcast untyped mem (rocshmem_broadcastmem_wg/wave)
Retained wrappers with valid public API:
- alltoall typed wg (rocshmem_TYPE_alltoall_wg)
- tile_broadcast variants (rocshmem_tile_broadcast{,_wave,_wg})
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abouteiller
reviewed
Oct 7, 2026
abouteiller
approved these changes
Oct 7, 2026
abouteiller
left a comment
abouteiller
left a comment
Contributor
There was a problem hiding this comment.
minor comment issue, needs merge
Contributor
TheRock Submodule Bump ActivityNewest first
|
anujshuk-amd
pushed a commit
that referenced
this pull request
Oct 12, 2026
## Motivation Add C wrappers for alltoall and broadcast. ## Technical Details C wrappers are needed by PyTorch to enable these APIs for Triton ROCSHMEM: - rocshmem_ctx_alltoallmem_wg - rocshmem_ctx_broadcastmem_wg ## Issue Tracking JIRA ID: AIROCSHMEM-546 ## Test Plan Disassemble build/librocshmem_device_gfx950.bc to LLVM IR text and verify that all expected wrapper functions are present as unmangled C symbols. ## Test Result From the full symbol list above, all wrappers are visible as plain, unmangled C names. Additionally, at least one test for alltoall and one test for broadcast have been added to tests/functional_tests/device_bitcode_tester.cpp. ## Submission Checklist --------- Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add C wrappers for alltoall and broadcast.
Technical Details
C wrappers are needed by PyTorch to enable these APIs for Triton ROCSHMEM:
rocshmem_ctx_alltoallmem_wg
rocshmem_ctx_broadcastmem_wg
Issue Tracking
JIRA ID: AIROCSHMEM-546
Test Plan
Disassemble build/librocshmem_device_gfx950.bc to LLVM IR text and verify that all expected wrapper functions are present as unmangled C symbols.
Test Result
From the full symbol list above, all wrappers are visible as plain, unmangled C names. Additionally, at least one test for alltoall and one test for broadcast have been added to tests/functional_tests/device_bitcode_tester.cpp.
Submission Checklist