Skip to content

[rocjitsu][web] Add web deployment workflow - #12588

Merged
atgutier merged 3 commits into
developfrom
users/RattataKing/publish-rocjitsu-website
Oct 6, 2026
Merged

atgutier merged 3 commits into
developfrom
users/RattataKing/publish-rocjitsu-website

Conversation

@RattataKing

@RattataKing RattataKing commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Move rocjitsu dashboard web source code from rocjitsu/website/ -> rocjitsu/website/dashboard/.
Add workflow to auto deploy web when changes added to the web codebase.
Issue ID: #10852, #12589

@RattataKing
RattataKing requested review from a team and atgutier as code owners September 30, 2026 21:54
@github-actions github-actions Bot added documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code project: rocjitsu labels Sep 30, 2026
@therock-pr-bot

therock-pr-bot Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: emulation/rocjitsu/website/dashboard/eslint.config.js, emulation/rocjitsu/website/dashboard/playwright.config.js, emulation/rocjitsu/website/dashboard/playwright.production.config.js, emulation/rocjitsu/website/dashboard/src/App.jsx, emulation/rocjitsu/website/dashboard/src/components/benchmarks/AggregatePerformanceChart.jsx (+70 more); no test file found
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would help to update the remaining documentation to match the move and automatic deployment:

  • emulation/rocjitsu/README.md:59 lists website/rocjitsu-dashboard/; the source directory is website/dashboard/.
  • emulation/rocjitsu/website/dashboard/docs/build-and-test.md:124 still says there is no deployment workflow. Please point it to rocjitsu-publish-website.yml, which publishes dist/ from develop to gh-pages/rocjitsu-dashboard/, while benchmark data remains independently published on gh-pages-rocjitsu.

@RattataKing
RattataKing requested a review from kuhar October 1, 2026 04:36

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RattataKing
RattataKing force-pushed the users/RattataKing/publish-rocjitsu-website branch from f310057 to d87a789 Compare October 1, 2026 18:20
@RattataKing
RattataKing removed this pull request from stack #12591 October 6, 2026 14:42
@atgutier
atgutier merged commit f64e270 into develop Oct 6, 2026
419 of 432 checks passed
@atgutier
atgutier deleted the users/RattataKing/publish-rocjitsu-website branch October 6, 2026 14:51
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code organization: ROCm project: rocjitsu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants