Skip to content

ci(amdsmi): run Python 3.6/3.7 legs without apt - #12587

Merged
JeniferC99 merged 1 commit into
developfrom
users/dgalants/amdsmi-pyver-ci-no-apt
Oct 2, 2026
Merged

JeniferC99 merged 1 commit into
developfrom
users/dgalants/amdsmi-pyver-ci-no-apt

Conversation

@dmitrii-galantsev

Copy link
Copy Markdown
Contributor

The Python 3.6 and 3.7 legs of AMDSMI Python Version Tests fail on every PR and on develop (for example run 36780340154) at apt-get install git:

Err:18 http://deb.debian.org/debian-security bullseye-security/main amd64 git amd64 1:2.30.2-1+deb11u5
  404  Not Found

Debian 11 LTS has ended and bullseye-security is being moved to the archive. The index on deb.debian.org still lists the +deb11uN packages, but their pool files are gone, and archive.debian.org doesn't have them yet.

This change checks out on the host and runs the tests inside the same python:3.x-slim-bullseye images with docker run, so these legs no longer install anything from Debian. The 3.8–3.14 legs are unchanged.

Tested: ran the new docker run command locally with both images. 3.6.15 and 3.7.17 pass.

Debian 11 security updates are being moved to archive.debian.org: the
bullseye-security index on deb.debian.org still lists +deb11uN packages
but their pool files now 404, so 'apt-get install git' fails in the
python:3.6/3.7-slim-bullseye containers and both legs go red.

Check out on the host and run the tests in the image with docker run,
so the legs no longer install anything from Debian mirrors.
Copilot AI balanced review requested due to automatic review settings September 30, 2026 21:52
@dmitrii-galantsev
dmitrii-galantsev requested a review from a team as a code owner September 30, 2026 21:52
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Sep 30, 2026
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflow change directly resolves the documented package-installation failure without altering test coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Moves Python 3.6/3.7 AMDSMI tests to explicit Docker runs, avoiding unavailable Debian packages.

Changes:

  • Performs checkout on the host.
  • Runs legacy Python tests in existing container images.
  • Leaves Python 3.8–3.14 execution unchanged.
File Description
.github/​workflows/​amdsmi-python-versions.yml Separates host and container test execution paths.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dmitrii-galantsev

Copy link
Copy Markdown
Contributor Author

i temporarily disabled the python workflows until this is merged

@JeniferC99
JeniferC99 merged commit 7290e7d into develop Oct 2, 2026
425 of 451 checks passed
@JeniferC99
JeniferC99 deleted the users/dgalants/amdsmi-pyver-ci-no-apt branch October 2, 2026 17:05
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants