[Groverkss]

Motivation

Represent AQL and PM4 as the initial packet format of a compute queue, with one owner for registration, VM lifetime, CP register state, dispatches, and teardown.

Technical Details

• Replace separate AQL, native PM4, and DRM queue ownership with ComputeQueueConfig and ComputeQueueRecord.
• Use a common compute queue binding factory while retaining existing PM4 entry points as adapters.
• Keep root packet format and cursor units explicit: AQL uses packet slots; PM4 uses dwords.
• Route native KFD PM4 queues through the common owner and preserve target-XCC selection.
• Retain VM snapshots and durable cursor publication across retries, and share queue suspension and cancellation with shader dispatches.
• Keep existing AQL vendor IB behavior for the follow-up PR.

KFD reference: set_queue_properties_from_user maps COMPUTE and COMPUTE_AQL to the same compute queue type, with format configured separately.

Existing exception handling is retained; this change adds no explicit throw statements or try/catch blocks.

Issue Tracking

Related discussion: #12526. This PR establishes the shared queue model used by the follow-up IB fix.

Test Plan

• Build rocjitsu_tests and interposer_dup_test with AMD Clang in Release mode, including the existing -Werror checks.
• Run selected AQL, PM4, VM, queue registration, doorbell, completion, KFD, XCD, MES, and PCI unit tests.
• Run all InterposerPm4Test cases with the gfx1100_w7900 and gfx1201_r9700 emulator configurations.
• Run the command processor/SDMA, SDMA frontend, MES frontend, and GPU memory architecture checks.

Test Result

• Both build targets passed for this commit independently of the follow-up.
• 280 selected unit tests passed.
• 64 PM4 interposer tests and four architecture checks passed.
• Commit hooks and git diff --check passed.
• No physical GPU execution was used for these results.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🎉 All checks passed! This PR is ready for review.

[Copilot]

Copilot review overview

🟡 Changes recommended

PM4 retry snapshots, ring reconfiguration, idle reporting, and encoded scheduling percentages have correctness gaps.

Review effort: Balanced
Findings: 1 · 3

Open (4)

• Reset stale PM4 producer state when changing rings · New
• Split XCC target from PM4 scheduling percentage · New
• Include PM4 activity in HQD idle detection · New
• Retain access and pending state for retryable PM4 initialization · New

What changed in this PR

Unifies AQL, native PM4, and DRM compute queues under shared ownership, lifecycle, and command state.

Changes:

• Introduces common compute queue configuration, records, and binding factory.
• Integrates PM4 ring processing, retries, dispatches, and teardown into CommandProcessor.
• Enables native KFD PM4 queues with target-XCC selection and expanded regression coverage.

File	Description
tests/​xcd_fanout_kfd_test.cpp	Updates unified queue terminology.
tests/​xcd_distribution_test.cpp	Uses common queue configuration.
tests/​pm4_queue_controller_test.cpp	Adds PM4 retry, wrap, snapshot, and cancellation tests.
tests/​pci/​gpu_pci_device_test.cpp	Uses the common binding factory.
tests/​kfd_ioctl_test.cpp	Tests native PM4 queue creation and XCC placement.
tests/​gpu_vm_service_test.cpp	Migrates queue lifecycle tests to common state.
tests/​gpu_vm_pipeline_test.cpp	Updates queue configuration type.
tests/​execution_plugin_test.cpp	Updates queue configuration type.
tests/​completion_tracker_test.cpp	Uses unified queue records.
tests/​check_sdma_frontend_boundary.cmake	Extends boundary checks for the new factory.
tests/​check_cp_sdma_boundary.cmake	Updates command-processor source boundaries.
tests/​cdna5_sdma_test.cpp	Migrates direct queue registrations.
tests/​aql_queue.h	Uses common queue configuration.
tests/​amdgpu_vm_test.cpp	Migrates AQL and DRM queue tests.
vm/​soc.cpp	Routes AQL bindings through the common factory.
pm4/​pm4_queue_binding_factory.cpp	Retains PM4 factory as an adapter.
pm4.h	Generalizes PM4 stream and command state.
dispatch_entry.h	Defines unified queue configuration and runtime state.
compute_queue_binding_factory.h	Declares the common binding factory.
compute_queue_binding_factory.cpp	Implements AQL and PM4 bindings.
completion_tracker.h	Accepts unified queue records.
completion_tracker.cpp	Migrates completion processing.
command_processor.h	Exposes unified queue APIs and storage.
command_processor.cpp	Consolidates queue execution and lifecycle logic.
CMakeLists.txt	Builds the renamed common factory.
simulated_kfd.cpp	Enables native KFD PM4 queues and XCC selection.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[kuhar]

Can we migrate the remaining controller contract tests to CommandProcessor and update the ownership documentation as part of this change or a focused follow-up? Production queues now use the unified record, but emulation/rocjitsu/tests/pm4_queue_controller_test.cpp still exercises the old controller for reconfiguration and retry behavior, allowing those tests to pass while the production path differs.

The same cleanup should update emulation/rocjitsu/docs/architecture.md:142, docs/vm-design.md:36, and lib/rocjitsu/src/rocjitsu/vm/amdgpu/command_processor.cpp:4783 (the latter two relative to emulation/rocjitsu/). They still describe the old owner or separate PM4 locking, although command streams now run under hw_queue_mutex_. Retire the unused implementation when those tests are migrated; if it must remain supported, document that boundary.

[systems-assistant]

TheRock Submodule Bump Activity

Newest first

• 2026-10-05 — Included in TheRock via ROCm/TheRock#8732.