Repository navigation
refactor(rocprofiler-compute): Extract analyze and membw helpers - #12532
Merged
vedithal-amd merged 5 commits intoOct 8, 2026
Merged
vedithal-amd merged 5 commits into
vedithal-amd merged 5 commits into
Conversation
abchoudh-amd
force-pushed
the
users/abchoudh/aiprofcomp-868/3-kernel-list
branch
from
October 1, 2026 11:38
1b2b50e to
fb869e9
Compare
abchoudh-amd
force-pushed
the
users/abchoudh/aiprofcomp-868/4-analyze-plumbing
branch
2 times, most recently
from
October 5, 2026 04:49
5d4e4da to
de5ee62
Compare
github-actions
Bot
added
documentation
abchoudh-amd
changed the base branch from
users/abchoudh/aiprofcomp-868/3-kernel-list
to
rocprofiler-compute-develop
October 5, 2026 04:51
abchoudh-amd
added
project: rocprofiler-compute
and removed
project: rocjpeg
project: rocr-debug-agent
project: rocjitsu
project: cuid
project: hrr
documentation
abchoudh-amd
marked this pull request as ready for review
October 5, 2026 09:12
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused extractions preserve existing behavior, include regression coverage, and have no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Extracts reusable rocprofiler-compute analysis helpers for upcoming HTML memory charts while preserving existing CLI output.
Changes:
- Exposes GPU/dispatch filtering and hidden-column selection helpers.
- Separates memory bandwidth summaries, specification loading, and evaluation.
- Adds focused regression tests and registers summary tests.
| File | Description |
|---|---|
| projects/rocprofiler-compute/tests/unit/utils/test_tty.py | Tests column selection and configuration isolation. |
| projects/rocprofiler-compute/tests/unit/utils/test_parser.py | Tests filtering combinations and dispatch validation. |
| projects/rocprofiler-compute/tests/unit/membw_analysis/test_membw_summary.py | Tests status text and active-node detection. |
| projects/rocprofiler-compute/tests/unit/membw_analysis/test_membw_engine.py | Tests specification loading and dataframe evaluation. |
| projects/rocprofiler-compute/tests/test_categories.yaml | Adds summary tests to test categories. |
| projects/rocprofiler-compute/src/utils/tty.py | Uses extracted summary and column helpers. |
| projects/rocprofiler-compute/src/utils/parser.py | Exposes filtering without kernel restrictions. |
| projects/rocprofiler-compute/src/membw_analysis/summary.py | Provides terminal-independent summary helpers. |
| projects/rocprofiler-compute/src/membw_analysis/engine.py | Separates specification loading from evaluation. |
| projects/rocprofiler-compute/CMakeLists.txt | Registers summary tests and coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xuchen-amd
approved these changes
Oct 6, 2026
xuchen-amd
left a comment
xuchen-amd
left a comment
Contributor
There was a problem hiding this comment.
thanks for working on this! please check typing suggestions.
vedithal-amd
approved these changes
Oct 6, 2026
abchoudh-amd
force-pushed
the
users/abchoudh/aiprofcomp-868/4-analyze-plumbing
branch
from
October 7, 2026 05:40
1aa2b01 to
80d187a
Compare
- Keep the analyzer extraction aligned with its current no-data handling. - Leave the chart-only filter API for the branch that first consumes it.
abchoudh-amd
force-pushed
the
users/abchoudh/aiprofcomp-868/4-analyze-plumbing
branch
from
October 8, 2026 05:41
80d187a to
a311d29
Compare
Contributor
|
override merging due to enough green CI signal - the RCCL PR Gating Hang will be fixed by #12843 |
vedithal-amd
deleted the
users/abchoudh/aiprofcomp-868/4-analyze-plumbing
branch
October 8, 2026 14:43
xuchen-amd
added a commit
that referenced
this pull request
Oct 8, 2026
…ry_chart_json_layouts Resolves the src/utils/tty.py import conflict with #12532: keep its membw_analysis.summary imports, take the memory_chart renderer imports, and drop the replaced mem_chart_gfx* modules and the now-unused BottleneckNode. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
vedithal-amd
pushed a commit
that referenced
this pull request
Oct 25, 2026
) ## Motivation The memory chart HTML work needs reusable row filters, terminal column choices, and memory bandwidth summaries. This refactor preserves the existing analyze output. ## Technical Details - Expose GPU and dispatch filtering for chart views while preserving CLI kernel-scoped dispatch validation. - Extract hidden-column resolution and memory bandwidth status text from terminal rendering. - Separate memory bandwidth tree loading from dataframe evaluation while keeping its existing warnings. - Cover the extracted parser, terminal, summary, and engine behavior with unit tests. ## JIRA ID JIRA ID: AIPROFCOMP-868 ## Test Plan - [x] Run ctest for the parser, TTY, and memory bandwidth analysis targets. ## Test Result - [x] ctest for the parser, TTY, and memory bandwidth analysis targets pass ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
vedithal-amd
pushed a commit
that referenced
this pull request
Oct 26, 2026
) ## Motivation The memory chart HTML work needs reusable row filters, terminal column choices, and memory bandwidth summaries. This refactor preserves the existing analyze output. ## Technical Details - Expose GPU and dispatch filtering for chart views while preserving CLI kernel-scoped dispatch validation. - Extract hidden-column resolution and memory bandwidth status text from terminal rendering. - Separate memory bandwidth tree loading from dataframe evaluation while keeping its existing warnings. - Cover the extracted parser, terminal, summary, and engine behavior with unit tests. ## JIRA ID JIRA ID: AIPROFCOMP-868 ## Test Plan - [x] Run ctest for the parser, TTY, and memory bandwidth analysis targets. ## Test Result - [x] ctest for the parser, TTY, and memory bandwidth analysis targets pass ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
lamikr
pushed a commit
that referenced
this pull request
Oct 27, 2026
) ## Motivation The memory chart HTML work needs reusable row filters, terminal column choices, and memory bandwidth summaries. This refactor preserves the existing analyze output. ## Technical Details - Expose GPU and dispatch filtering for chart views while preserving CLI kernel-scoped dispatch validation. - Extract hidden-column resolution and memory bandwidth status text from terminal rendering. - Separate memory bandwidth tree loading from dataframe evaluation while keeping its existing warnings. - Cover the extracted parser, terminal, summary, and engine behavior with unit tests. ## JIRA ID JIRA ID: AIPROFCOMP-868 ## Test Plan - [x] Run ctest for the parser, TTY, and memory bandwidth analysis targets. ## Test Result - [x] ctest for the parser, TTY, and memory bandwidth analysis targets pass ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The memory chart HTML work needs reusable row filters, terminal column choices, and memory bandwidth summaries. This refactor preserves the existing analyze output.
Technical Details
JIRA ID
JIRA ID: AIPROFCOMP-868
Test Plan
Test Result
Submission Checklist