Repository navigation
fix(rocr) - fix OpenCL API version in adrenaline window - #12506
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly aligns ROCr version reporting with existing platform and PAL formatting.
Review effort: Balanced
Findings: None
What changed in this PR
Updates ROCr OpenCL device version strings so Adrenalin displays complete API version information.
Changes:
- Appends AMD platform/build metadata to online and offline ROCr device version strings.
- Aligns ROCr formatting with the PAL backend.
| File | Description |
|---|---|
projects/clr/rocclr/device/rocm/rocdevice.cpp |
Adds AMD_PLATFORM_INFO to reported OpenCL versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chrispaquot
approved these changes
Sep 30, 2026
agunashe
force-pushed
the
users/agunashe/opencl_api_version_rocr
branch
from
October 5, 2026 21:27
fbc2e17 to
aa80642
Compare
Contributor
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
systems-assistant Bot
pushed a commit
to ROCm/clr
that referenced
this pull request
Oct 6, 2026
(#12506) ## Motivation fix(rocr) - fix OpenCL API version in adrenaline window with rocr backend ## Technical Details fix(rocr) - fix OpenCL API version in adrenaline window with rocr backend ## Issue Tracking JIRA ID: AIRUNTIME-2814 ## Test Plan adrenaline driver window should populate the OpenCL API version correctly ## Test Result adrenaline driver window should populate the OpenCL API version correctly ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#12506 (commit dfbfaa9)
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix(rocr) - fix OpenCL API version in adrenaline window with rocr backend
Technical Details
fix(rocr) - fix OpenCL API version in adrenaline window with rocr backend
Issue Tracking
JIRA ID: AIRUNTIME-2814
Test Plan
adrenaline driver window should populate the OpenCL API version correctly
Test Result
adrenaline driver window should populate the OpenCL API version correctly
Submission Checklist