Repository navigation
refactor the rbtree / interval tree in virtio thunk and fix issue for virtio driver - #12469
Merged
Merged
Conversation
HongleiHuang-amd
requested review from
atgutier,
cfreeamd,
dayatsin-amd,
kentrussell and
shwetagkhatri
as code owners
September 29, 2026 15:35
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
HongleiHuang-amd
force-pushed
the
users/honghuan/rbtree-fix
branch
from
September 29, 2026 15:42
191558b to
8afff35
Compare
dayatsin-amd
left a comment
dayatsin-amd
left a comment
Contributor
There was a problem hiding this comment.
It seems this patches is bringing in some other changes other than the RB Tree refactor.
Can you please move the other changes to a separate PR.
HongleiHuang-amd
force-pushed
the
users/honghuan/rbtree-fix
branch
from
October 1, 2026 00:19
8afff35 to
765593a
Compare
Contributor
Author
Got it, only keep the license scan fix commit now. |
HongleiHuang-amd
force-pushed
the
users/honghuan/rbtree-fix
branch
from
October 1, 2026 00:29
18ddeac to
0e0f851
Compare
dayatsin-amd
approved these changes
Oct 1, 2026
HongleiHuang-amd
force-pushed
the
users/honghuan/rbtree-fix
branch
from
October 1, 2026 14:03
0e0f851 to
fba8eea
Compare
cfreeamd
reviewed
Oct 1, 2026
cfreeamd
left a comment
cfreeamd
left a comment
Contributor
There was a problem hiding this comment.
🤖 AI-assisted pre-review (for @cfreeamd)
[Required] PR title refactor the rbtree / interval tree in virtio thunk and fix issue for virtio driver does not follow the required type(component): summary format that becomes the permanent squash-merge commit. Suggested: refactor(hsakmt): replace custom augmented interval tree with plain rbtree scan in virtio thunk.
Other files reviewed: hsakmt_interval_tree.c, hsakmt_interval_tree.h, hsakmt_virtio_memory.c. The algorithm is correct — interval_tree_scan starting from the BST minimum and terminating when node->start > last is a valid O(n) scan on a tree ordered by start. The O(n) complexity is explicitly documented in the header comment.
HongleiHuang-amd
force-pushed
the
users/honghuan/rbtree-fix
branch
2 times, most recently
from
October 8, 2026 03:13
dac749d to
d3849d7
Compare
github-actions
Bot
added
the
github actions
|
🎉 All checks passed! This PR is ready for review. |
HongleiHuang-amd
force-pushed
the
users/honghuan/rbtree-fix
branch
from
October 8, 2026 08:11
6b70d74 to
dac749d
Compare
…sed scan hsakmt_interval_tree.c/.h were a structural port of the Linux kernel's augmented rbtree (lib/rbtree.c, rbtree_augmented.h, interval_tree_generic.h), GPL-2.0 source carrying an MIT header (Palamida SWCSD-15612 finding). Keep the file names and public API (interval_tree_t, interval_tree_node_t, hsakmt_interval_tree_insert/remove/iter_first/iter_next) unchanged to avoid a wide-reaching rename and to keep the door open for a real augmented interval tree later; only the internal implementation changes. The new implementation is built on the existing BSD-2-Clause nginx-derived rbtree.c already used for bo_rbt. Ranges are ordered by start address and overlap queries do a bounded ascending scan instead of maintaining an augmented subtree-max invariant. This is O(n) worst case instead of O(log n), an acceptable trade-off given the small number of userptr/SVM ranges tracked per process. Signed-off-by: Honglei Huang <honghuan@amd.com>
HongleiHuang-amd
force-pushed
the
users/honghuan/rbtree-fix
branch
from
October 8, 2026 08:11
dac749d to
980c0b9
Compare
systems-assistant Bot
pushed a commit
to ROCm/ROCR-Runtime
that referenced
this pull request
Oct 9, 2026
rbtree-based scan hsakmt_interval_tree.c/.h were a structural port of the Linux kernel's augmented rbtree (lib/rbtree.c, rbtree_augmented.h, interval_tree_generic.h), GPL-2.0 source carrying an MIT header (Palamida SWCSD-15612 finding). Keep the file names and public API (interval_tree_t, interval_tree_node_t, hsakmt_interval_tree_insert/remove/iter_first/iter_next) unchanged to avoid a wide-reaching rename and to keep the door open for a real augmented interval tree later; only the internal implementation changes. The new implementation is built on the existing BSD-2-Clause nginx-derived rbtree.c already used for bo_rbt. Ranges are ordered by start address and overlap queries do a bounded ascending scan instead of maintaining an augmented subtree-max invariant. This is O(n) worst case instead of O(log n), an acceptable trade-off given the small number of userptr/SVM ranges tracked per process. Signed-off-by: Honglei Huang <honghuan@amd.com> [rocm-systems] ROCm/rocm-systems#12469 (commit 63802ea)
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor rbtree/interval tree with internal implementation
Technical Details
refactor the rbtree in virtio thunkloader
Issue Tracking
JIRA ID : SWCSD-12742
Test Plan
rocr
hiptest
Test Result
all pass