Skip to content

test(rccl): add host microtests for src/ras/diagnostics_gpu.cc #12436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduforest merged 10 commits into from
Oct 12, 2026
Merged

test(rccl): add host microtests for src/ras/diagnostics_gpu.cc #12436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a6a2e40
test(rccl): add host microtests for diagnostics_gpu.cc
aduforest Sep 28, 2026
94f5168
test(rccl): cover diagnostics gpu failure paths
aduforest Sep 30, 2026
0489e66
Merge develop and preserve both RAS and tuning test registration
aduforest Oct 1, 2026
aa4008f
test(rccl): address RAS diagnostics review feedback
aduforest Oct 2, 2026
84007e7
Merge develop and update GPU diagnostics NVML test fakes
aduforest Oct 6, 2026
8355d9c
Merge develop after diagnostics host tests
aduforest Oct 6, 2026
aeb2e02
test(rccl): cover NVIDIA graphics driver diagnostics
aduforest Oct 6, 2026
5283ff8
Merge develop after ras_param host tests
aduforest Oct 7, 2026
c205110
Merge remote-tracking branch 'origin/develop' into fix/12436-merge-de…
aduforest Oct 9, 2026
7d8f57b
Merge remote-tracking branch 'origin/develop' into users/aduforest/ra…
aduforest Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/rccl/test/host/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ function(rccl_define_micro_source_lists)
ras-diagnostics-common-test.cc # src/ras/diagnostics_checks_common.cc
ras-collectives-test.cc # src/ras/collectives.cc
ras-diagnostics-test.cc # src/ras/diagnostics.cc
ras-diagnostics-gpu-test.cc # src/ras/diagnostics_gpu.cc
ras-peers-test.cc # src/ras/peers.cc
ras-diagnostics-env-test.cc # src/ras/diagnostics_env.cc
ras-param-test.cc # src/ras/ras_param.cc
Expand Down Expand Up @@ -822,6 +823,7 @@ rccl_add_micro_binary(rccl-UnitTestsMicro
# so add_file_unique() renames this one. Re-check after any source-list reorder.
COLLECTIVES_CC_PATH="${RCCL_HOST_HIPIFY_DIR}/src/ras/collectives_tmp.cc"
RAS_DIAGNOSTICS_CC_PATH="${RCCL_HOST_HIPIFY_DIR}/src/ras/diagnostics_tmp.cc"
RAS_DIAGNOSTICS_GPU_CC_PATH="${RCCL_HOST_HIPIFY_DIR}/src/ras/diagnostics_gpu.cc"
RAS_PEERS_CC_PATH="${RCCL_HOST_HIPIFY_DIR}/src/ras/peers.cc"
RAS_DIAGNOSTICS_ENV_CC_PATH="${RCCL_HOST_HIPIFY_DIR}/src/ras/diagnostics_env.cc"
RAS_PARAM_CC_PATH="${RCCL_HOST_HIPIFY_DIR}/src/ras/ras_param.cc"
Expand Down
12 changes: 12 additions & 0 deletions projects/rccl/test/host/MICROTEST_README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ export colliding non-`static` symbols; otherwise a unit needs its own binary:
before validation. Its raw-byte fixture reproduces the enum UBSan failure;
enable it after the production fix. The defined `RAS_DIAG_CHECK_COUNT`
sentinel remains covered by enabled dispatch and peer-payload tests.
- `ras/diagnostics_gpu.cc` (`RAS_DIAGNOSTICS_GPU_CC_PATH`, from
`ras-diagnostics-gpu-test.cc`); suite `RasDiagnosticsGpuMicrotest.*`. Covers
GPU inventory, CUDA and NVIDIA graphics driver versions, ECC, and NVLink
collection and summaries, including failed NVML queries and bounded
driver-version strings.
- `ras/peers.cc` (`RAS_PEERS_CC_PATH`, from `ras-peers-test.cc`); suite
`RasPeersMicrotest.*`. Covers peer conversion and merging, update
propagation, link selection, dead-peer tracking, address ordering, and
Expand Down Expand Up @@ -867,6 +872,13 @@ the old registry and preserves explicit vacant slots. The RAS and diagnostics
suites use the same helper. `fakes/ras_diagnostics_test_support.h` shares the
owned communicator and recording reporter used by the diagnostic suites.

The GPU diagnostic suite exercises payload filling through the public collectors
and owns returned records with RAII. Each summarizer has an over-capacity rank
case; together they exercise all seven bounded rank arrays and check truncated
rank sets with total counts. ECC maxima are checked with the largest values on
an earlier rank, and incomplete-report fixtures include hexadecimal hashes
larger than nine.

`SetMicroEnviron` in `fakes/env_fakes.{h,cc}` replaces the scripted environment
for enumeration tests, preserving input order and malformed entries while
making valid entries visible through `micro_getenv` and `getenv`. While that
Expand Down
Loading
Loading