Repository navigation
test(rccl): fake the rocSHMEM host symbols the microtests need - #12337
Merged
Merged
Conversation
Contributor
Author
|
@argus re-review |
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
![amd-argus[bot]](https://avatars.githubusercontent.com/in/4740020?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lfmeadow
force-pushed
the
users/lmeadows/rocshmem-host-test-fakes
branch
from
September 28, 2026 17:41
de91c03 to
f267d94
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
./install.sh -t --rocshmem fails to link four host test binaries: init.cc and enqueue.cc reach their ENABLE_ROCSHMEM arms, and nothing in fakes/ defines the symbols those arms call. Adds them, in the fakes file named after the owning production TU. rocshmem_fakes.cc is conditional -- it includes rocshmem.hpp, which is only on the include path under ENABLE_ROCSHMEM. Verified with -t --ninja --rocshmem --address-sanitizer (3197/3197, was 3 link failures) and -t --ninja (4366/4366, unchanged).
The test targets resolved <rocshmem/rocshmem.hpp> from ${ROCM_PATH}/include,
a different rocSHMEM from the one librccl.so links, and nothing ordered them
after the sub-build that installs rccl's copy. Put ROCSHMEM_INCLUDE_DIR first
and add the ordering.
Also drops a build log committed by accident, registers ResetRocshmemFakes in
the Init reset chain, adds the third result seam, and removes the standalone
source-list branch, which never defines ENABLE_ROCSHMEM.
…view
The three seams take the calls' own parameters, with a Default* each and a
drift check against the real declarations. rocshmem_malloc's state moves to
file scope so ResetRocshmemFakes clears it. The rocSHMEM include directory
goes just ahead of ${ROCM_PATH}/include rather than first, and two comments
are corrected.
lfmeadow
force-pushed
the
users/lmeadows/rocshmem-host-test-fakes
branch
from
September 28, 2026 19:55
f267d94 to
c09b80b
Compare
Contributor
Author
|
@argus re-review |
abouteiller
approved these changes
Sep 29, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : LCOMPILER-2794
./install.sh -t --rocshmemfails to link four host test binaries.init.ccandenqueue.ccreach theirENABLE_ROCSHMEMarms, and nothing infakes/defines the ten symbols those arms call. Each fake goes in the file named after the owning production TU;rocshmem_fakes.ccis new and conditional, since it includesrocshmem.hpp.Pre-existing, but unreachable under ninja until #12331 let
--rocshmemstart building.Test
-t --ninja --rocshmem --address-sanitizer: 3197/3197, was 3 link failures-t --ninja: 4366/4366, unchanged