Skip to content

fix(hrr): make the capture writer safe across fork and in the crash path #12255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andraghetti merged 21 commits into from
Oct 8, 2026
Merged

fix(hrr): make the capture writer safe across fork and in the crash path #12255

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
beec6a3
fix(hrr): make the capture writer safe across fork and in the crash path
andraghetti Sep 25, 2026
7877d8d
fix(hrr): clear the emergency manifest flag in a forked child
andraghetti Sep 28, 2026
d9a8d5f
docs(hrr): state the writer lock order and what bounds the buffer wait
andraghetti Sep 29, 2026
771f55e
test(hrr): cover fork while recording and a crash on a small stack
andraghetti Oct 1, 2026
2261740
fix(hrr): reopen a forked child's archive on its first record
andraghetti Oct 1, 2026
0e379d5
fix(hrr): declare the fork reopen state apart from develop's new globals
andraghetti Oct 1, 2026
cb97fa4
fix(hrr): clear the inherited capture-incomplete flag in a forked child
andraghetti Oct 1, 2026
5918d50
fix(hrr): stop the fork-while-recording loop at the first hung child
andraghetti Oct 1, 2026
390067b
Merge branch 'develop' into users/andraghetti/hrr-capture-fork-crash
andraghetti Oct 5, 2026
403613f
test(hrr): cover the writer mutex across fork and a crash during fork
andraghetti Oct 5, 2026
3daf63e
fix(hrr): hold the unreplayable-API mutex across fork
andraghetti Oct 5, 2026
09c9d27
fix(hrr): keep a forked child from opening its archive after close
andraghetti Oct 5, 2026
a5fb668
fix(hrr): keep a child forked after close from opening an archive
andraghetti Oct 5, 2026
353fa9f
fix(hrr): finalize a forked child's archive only after it is open
andraghetti Oct 6, 2026
1260f51
Merge branch 'develop' into users/andraghetti/hrr-capture-fork-crash
andraghetti Oct 6, 2026
35226f2
test(hrr): record in the forked child of the disk-space fork tests
andraghetti Oct 6, 2026
9cc1ef7
Merge branch 'develop' into users/andraghetti/hrr-capture-fork-crash
andraghetti Oct 6, 2026
a966925
test(hrr): share one fsync between the fork and disk-space tests
andraghetti Oct 6, 2026
3d0e699
Merge branch 'develop' of github.com:ROCm/rocm-systems into HEAD
andraghetti Oct 7, 2026
7e625df
fix(hrr): drop a record that comes after the capture's trailer
andraghetti Oct 7, 2026
b63e660
fix(hrr): open no archive in a child forked after the capture's flush
andraghetti Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading