Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
0fce132
fix(hrr): keep capture archives private and refuse planted links
andraghetti Sep 25, 2026
4b7a41d
fix(hrr): check the inode before truncating the crash-path manifest
andraghetti Sep 28, 2026
90806b8
fix(hrr): uninstall shims in a fork child that cannot open its archive
andraghetti Sep 29, 2026
60c8d81
fix(hrr): keep atomically written files 0600 whatever the umask
andraghetti Sep 30, 2026
2a39dec
test(hrr): match the whole refusal message in the capture access tests
andraghetti Sep 30, 2026
09fc1f3
fix(hrr): claim each blob prefix before indexing its blobs on resume
andraghetti Oct 1, 2026
d4167fe
fix(hrr): keep the fstat and fchmod error when events.bin is rejected
andraghetti Oct 1, 2026
d64b8d0
fix(hrr): remove the empty archive directories a failed open leaves
andraghetti Oct 1, 2026
227ae82
fix(hrr): start a forked child's archive complete; test planted blob …
andraghetti Oct 1, 2026
8abc742
fix(hrr): check the planted-prefix capture by its manifest, not stderr
andraghetti Oct 1, 2026
e8f2e20
fix(hrr): open events.bin with O_NONBLOCK like the archive's other files
andraghetti Oct 1, 2026
f149f9c
fix(hrr): trust a resumed blob only if this user wrote it
andraghetti Oct 1, 2026
ae8e091
fix(hrr): keep the PyTorch region producer to the archive's private m…
andraghetti Oct 1, 2026
5dcddff
fix(hrr): read archive state files only when they are ours and single…
andraghetti Oct 1, 2026
e5d99a9
fix(hrr): set the PyTorch region directory to 0700 and open the file …
andraghetti Oct 1, 2026
b0de37b
fix(hrr): restore the compiler dispatch table when capture is uninsta…
andraghetti Oct 1, 2026
62d9c83
fix(hrr): treat capture as active only when the archive has its event…
andraghetti Oct 1, 2026
710f08f
fix(hrr): refuse to resume an archive whose events.bin cannot be scanned
andraghetti Oct 1, 2026
bbab5da
Merge branch 'develop' into users/andraghetti/hrr-capture-private-arc…
andraghetti Oct 5, 2026
0c8b3e7
test(hrr): cover the capture writer's failure paths and the PyTorch p…
andraghetti Oct 5, 2026
203c5f6
fix(hrr): tell producers capture is on with pid-<pid>/active, not eve…
andraghetti Oct 5, 2026
2eeb7ad
fix(hrr): do not resume an archive whose trailer or torn tail cannot …
andraghetti Oct 6, 2026
eccbd71
Merge branch 'develop' into users/andraghetti/hrr-capture-private-arc…
andraghetti Oct 6, 2026
fac101e
Merge branch 'develop' into users/andraghetti/hrr-capture-private-arc…
andraghetti Oct 6, 2026
ba65873
fix(hrr): remove the active marker when capture stops for space
andraghetti Oct 7, 2026
c82c8dc
fix(hrr): name the process instance in the active marker
andraghetti Oct 7, 2026
8565d1f
docs(hrr): describe the active marker's process line
andraghetti Oct 7, 2026
f7ca3d5
Merge branch 'develop' of github.com:ROCm/rocm-systems into users/and…
andraghetti Oct 7, 2026
f86b3f1
test(hrr): check that a refused forked child runs no capture shim
andraghetti Oct 7, 2026
35dc92b
fix(hrr): set errno when a file inside the archive is refused
andraghetti Oct 7, 2026
1b89720
Merge branch 'develop' into users/andraghetti/hrr-capture-private-arc…
andraghetti Oct 8, 2026
377a34c
Merge branch 'develop' into users/andraghetti/hrr-capture-private-arc…
andraghetti Oct 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion projects/clr/hipamd/src/hrr/hip_capture.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1616,7 +1616,12 @@ void hip_capture_init() {
}

// Open the events writer now — Flag::init() has run so output_dir is valid.
if (!hrr_cap::writer::open(hip_capture_output_dir())) return;
// Without a writer the shims would only cost time, and the D2H ones still
// synchronize streams, so take them out again.
if (!hrr_cap::writer::open(hip_capture_output_dir())) {
hip_capture_uninstall();
return;
}

hrr_cap::writer::set_capture_metadata_json(
hrr_cap::metadata::collect_json());
Expand Down
Loading
Loading