Repository navigation
[rocprofiler-sdk] : support SPM reference-clock sample intervals - #12213
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Base automatically changed from
users/bingma/gfx12-spm-support-aqlprofile
to
develop
September 24, 2026 20:07
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
sauverma93
force-pushed
the
users/sauverma/spm-refclk
branch
from
September 28, 2026 14:55
4c28358 to
e6618f6
Compare
sauverma93
changed the base branch from
develop
to
users/sauverma/spm-sa-wgp
September 29, 2026 08:01
sauverma93
force-pushed
the
users/sauverma/spm-refclk
branch
from
September 29, 2026 08:01
e6618f6 to
ab4e0a2
Compare
sauverma93
changed the base branch from
users/sauverma/spm-sa-wgp
to
develop
September 29, 2026 08:08
sauverma93
changed the base branch from
develop
to
users/sauverma/spm-sa-wgp
September 29, 2026 08:08
sauverma93
marked this pull request as ready for review
September 29, 2026 11:33
sauverma93
changed the title
SrirakshaNag
requested changes
Sep 30, 2026
ApoKalipse-V
reviewed
Oct 9, 2026
sauverma93
force-pushed
the
users/sauverma/spm-refclk
branch
2 times, most recently
from
October 10, 2026 12:43
4210e82 to
c9a890b
Compare
sauverma93
force-pushed
the
users/sauverma/spm-refclk
branch
5 times, most recently
from
October 12, 2026 16:41
8b85083 to
f40cf2c
Compare
SrirakshaNag
approved these changes
Oct 12, 2026
SrirakshaNag
left a comment
SrirakshaNag
left a comment
Contributor
There was a problem hiding this comment.
Please address the comment on docs
bing-ma
requested changes
Oct 12, 2026
bing-ma
left a comment
bing-ma
left a comment
Contributor
There was a problem hiding this comment.
Please fix the minor doc issue that Sriraksha pointed out around the rocprofv3-avail command wording.
sauverma93
force-pushed
the
users/sauverma/spm-refclk
branch
2 times, most recently
from
October 12, 2026 20:42
b2828e8 to
a7655f8
Compare
sauverma93
force-pushed
the
users/sauverma/spm-refclk
branch
2 times, most recently
from
October 13, 2026 13:08
324c226 to
2bcc85d
Compare
SPM sample intervals were always programmed in shader-clock cycles even though aqlprofile exposes a reference-clock sampling mode on gfx1250. Add ROCPROFILER_SPM_PARAMETER_TYPE_SAMPLE_INTERVAL_REFCLK_CYCLES and plumb it from the rocprofv3 --spm-sample-interval-unit refclk_cycles option through the tool configuration into the aqlprofile SAMPLE_MODE parameter. Agent configuration queries now distinguish the two clocks by the aqlprofile interval mode instead of reporting every interval as SCLK. Reference-clock intervals are restricted to gfx1250: rocprofiler_spm_create_counter_config rejects them with ROCPROFILER_STATUS_ERROR_INVALID_ARGUMENT on other agents, and the configuration query does not advertise REFCLK there, so rocprofv3 fails before configuring a run. Extend the query unit test to assert per-architecture interval ranges and REFCLK availability, add a gfx1250-only rocprofv3 refclk integration test, and document the new unit in the SPM how-to guide.
sauverma93
force-pushed
the
users/sauverma/spm-refclk
branch
from
October 13, 2026 17:02
2bcc85d to
88e40bf
Compare
Contributor
|
1 task done
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SPM sample intervals were always programmed in shader-clock cycles. aqlprofile already exposes a reference-clock sampling mode on gfx1250, and rocprofv3 had no way to select it.
Technical Details
ROCPROFILER_SPM_PARAMETER_TYPE_SAMPLE_INTERVAL_REFCLK_CYCLES.--spm-sample-interval-unit refclk_cyclesfrom rocprofv3 through the tool configuration into the aqlprofileSAMPLE_MODEparameter.rocprofiler_spm_create_counter_configreturnsROCPROFILER_STATUS_ERROR_INVALID_ARGUMENTon other agents, and the configuration query does not advertise a reference-clock interval there.Issue Tracking
ISSUE ID: AIPROFSDK-1151
Test Plan
spm_core.query_agent_configurations: shader-clock minimum is 1 on gfx1250 and 32 on other SPM architectures. A reference-clock interval with minimum 1 is present only on gfx1250.rocprofv3-test-spm-refclk-json-execute: runsimple-transposewith--spm-sample-interval-unit refclk_cyclesand write a JSON profile.rocprofv3-test-spm-refclk-json-validate: compare that JSON with a normal PMC run, the same way as the shader-clock SPM test.refclk_cyclesfails before the run is configured.Test Result
Local unit test
spm_core.query_agent_configurationspassed.rocprofv3 --helplists--spm-sample-interval-unit {sclk_cycles,refclk_cycles}. Validated on gfx1250: arefclk_cyclesSPM run produces samples.Submission Checklist