Unit & feature tests infrastructure by motokultivator · Pull Request #12199 · ROCm/rocm-systems

motokultivator · 2026-09-24T15:12:01Z

Summary

Introduces the build system plumbing required to host a GoogleTest-based unit and feature test suite for rocdbgapi.

ENABLE_TESTS is a master switch enabling all test tiers; ENABLE_UNIT_TESTS enables just the unit tier and can be toggled independently, matching the pattern already used by rocr-debug-agent. Both default OFF so downstream consumers (e.g. the TheRock superbuild) are not forced to pick up GoogleTest/GMock until they opt in with -DENABLE_TESTS=ON.
Reusable CMake helpers register unit test executables uniformly. GoogleTest resolution prefers GTest::* targets already provided by a parent project (e.g. the TheRock superbuild), falling back to find_package(GTest CONFIG) for a system installation. All four targets (gtest, gtest_main, gmock, gmock_main) must be present; incomplete installations fail with clear error messages and installation instructions.
test/CMakeLists.txt and test/unit/CMakeLists.txt define the test tree skeleton and per-target registration scaffolding. A minimal smoke test exercises both GoogleTest and GMock as a usage example.
Built unit test binaries install under tests/rocdbgapi relative to CMAKE_INSTALL_PREFIX.
All new CMake files use SPDX license headers (MIT).

Building the test suite requires GoogleTest and GMock, only when opted in with -DENABLE_TESTS=ON. The main README documents this as a build prerequisite with per-distro package names, and test/README.md documents the test tree layout, build switches, and usage without duplicating that material. The CHANGELOG records the new dependency and options.

ISSUE ID : AIROCGDB-634

Test plan

Configure with default options and confirm no test targets are built (tests off by default)
Configure with ENABLE_TESTS=ON and confirm the smoke test builds and passes
Configure with ENABLE_TESTS=ON -DENABLE_UNIT_TESTS=OFF and confirm behavior matches rocr-debug-agent's pattern
Verify build fails with a clear error message when GTest/GMock are not installed and tests are enabled
Verify install places unit test binaries under tests/rocdbgapi

🤖 Generated with Claude Code

therock-pr-bot · 2026-09-24T15:12:50Z

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	PR does not contain code files — Unit Test auto-passed
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-09-24T15:12:52Z

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

lumachad · 2026-09-28T12:56:47Z

Thanks. I'll start going through this one.

lumachad

Left some high level comments of what we should change. Mostly cleaning up the license headers and polishing up the GoogleTest/GMock/etc dependency discovery.

Downloading these dependencies wouldn't be acceptable I'm afraid.

lumachad · 2026-10-01T14:31:31Z

Looks like we have conflicts.

lumachad · 2026-10-06T10:17:49Z

@motokultivator FTR, I'm waiting for these conflicts to be cleaned up before I do another review.

motokultivator · 2026-10-06T12:03:18Z

@motokultivator FTR, I'm waiting for these conflicts to be cleaned up before I do another review.

Done. Sorry for the delay, I was OOO.

lumachad · 2026-10-06T13:46:25Z

@motokultivator Let's skip commit 2. What we want is just a clean cmake change that provides a way to build tests and then dummy examples of those tests in a second commit.

After that is in, then we can start adapting dbgapi's code to be testable.

For instance, the rocr-debug-agent unit testing effort: #12460

lumachad · 2026-10-07T14:25:39Z

This is still adding much more than required for smoke tests. We need just the cmake changes and a dummy smoke test.

motokultivator · 2026-10-08T11:16:39Z

This is still adding much more than required for smoke tests. We need just the cmake changes and a dummy smoke test.

How about this: CMake, a project skeleton, a README, and a smoke test as an example?
Still 9 files :(

lumachad · 2026-10-12T16:48:51Z

Labelling ci:skip until we pick up ROCm/TheRock#8943

amd-bfilipov

Gave this to my claude to compare this with similar PR that I have merged, by comparing comments on that PR and if any of those are applicable to this PR. None of them apply here and (or they have been addressed).
From my perspective, looks good, approved.

lumachad · 2026-10-19T09:11:36Z

Blocked by ROCm/TheRock#8943.

Introduce the build system plumbing required to host a GoogleTest based unit and feature test suite for rocdbgapi. ENABLE_TESTS is a master switch that enables all test tiers. ENABLE_UNIT_TESTS enables just the unit tier and can be toggled independently, matching the pattern used by rocr-debug-agent's ENABLE_TESTS and ENABLE_UNIT_TESTS options. Both default OFF so downstream consumers (e.g. TheRock superbuild) are not forced to pick up GoogleTest/GMock until they opt in with -DENABLE_TESTS=ON. Reusable helpers register unit test executables uniformly. GoogleTest resolution prefers GTest::* targets already provided by a parent project (e.g. TheRock superbuild) and otherwise uses find_package(GTest CONFIG) to locate a system installation. All four targets (gtest, gtest_main, gmock, gmock_main) must be present. Incomplete installations fail with clear error messages and installation instructions. test/CMakeLists.txt and test/unit/CMakeLists.txt define the test tree skeleton and per target registration scaffolding. A minimal smoke test exercises both GoogleTest and GMock as an example for usage. Built unit test binaries install under tests/rocdbgapi relative to CMAKE_INSTALL_PREFIX. All new CMake files use SPDX license headers (MIT). Building the test suite requires GoogleTest and GMock, only when opted in. The main README documents this as a build prerequisite with per distro package names, and test/README.md documents the test tree layout, build switches, and usage without repeating that material. The CHANGELOG records the new dependency and options. Co-Authored-By: Luis Machado <luis.machado@amd.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

lumachad · 2026-10-28T11:15:44Z

Disabled tests by default and merged, so we don't stay blocked by #8943.

Introduce the build system plumbing required to host a GoogleTest based unit and feature test suite for rocdbgapi. ENABLE_TESTS is a master switch that enables all test tiers. ENABLE_UNIT_TESTS enables just the unit tier and can be toggled independently, matching the pattern used by rocr-debug-agent's ENABLE_TESTS and ENABLE_UNIT_TESTS options. Both default OFF so downstream consumers (e.g. TheRock superbuild) are not forced to pick up GoogleTest/GMock until they opt in with -DENABLE_TESTS=ON. Reusable helpers register unit test executables uniformly. GoogleTest resolution prefers GTest::* targets already provided by a parent project (e.g. TheRock superbuild) and otherwise uses find_package(GTest CONFIG) to locate a system installation. All four targets (gtest, gtest_main, gmock, gmock_main) must be present. Incomplete installations fail with clear error messages and installation instructions. test/CMakeLists.txt and test/unit/CMakeLists.txt define the test tree skeleton and per target registration scaffolding. A minimal smoke test exercises both GoogleTest and GMock as an example for usage. Built unit test binaries install under tests/rocdbgapi relative to CMAKE_INSTALL_PREFIX. All new CMake files use SPDX license headers (MIT). Building the test suite requires GoogleTest and GMock, only when opted in. The main README documents this as a build prerequisite with per distro package names, and test/README.md documents the test tree layout, build switches, and usage without repeating that material. The CHANGELOG records the new dependency and options. Co-Authored-By: Luis Machado <luis.machado@amd.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> [rocm-systems] ROCm/rocm-systems#12199 (commit f9a7ae7)

systems-assistant · 2026-10-29T04:43:17Z

TheRock Submodule Bump Activity

Newest first

2026-10-29 — Included in TheRock via ROCm/TheRock#9567.

github-actions Bot added the project: rocdbgapi label Sep 24, 2026

therock-pr-bot Bot added the Not ready to Review label Sep 24, 2026

systems-assistant Bot added the organization: ROCm label Sep 24, 2026

lumachad reviewed Sep 28, 2026

View reviewed changes

lumachad assigned motokultivator Sep 28, 2026

motokultivator force-pushed the users/arikalo/rocdbgapi/unit_feature_tests branch from 4f83147 to 698323b Compare October 1, 2026 12:46

motokultivator force-pushed the users/arikalo/rocdbgapi/unit_feature_tests branch from 698323b to 6cf87ce Compare October 6, 2026 12:00

lumachad marked this pull request as ready for review October 6, 2026 13:42

lumachad requested a review from a team as a code owner October 6, 2026 13:42

lumachad assigned lumachad and unassigned motokultivator Oct 6, 2026

lumachad assigned motokultivator and unassigned lumachad Oct 6, 2026

motokultivator force-pushed the users/arikalo/rocdbgapi/unit_feature_tests branch from 6cf87ce to b202464 Compare October 7, 2026 13:36

motokultivator force-pushed the users/arikalo/rocdbgapi/unit_feature_tests branch from b202464 to 0f75900 Compare October 8, 2026 11:12

motokultivator force-pushed the users/arikalo/rocdbgapi/unit_feature_tests branch from 0f75900 to d131d6c Compare October 9, 2026 14:21

lumachad force-pushed the users/arikalo/rocdbgapi/unit_feature_tests branch from d131d6c to 995db06 Compare October 12, 2026 16:33

lumachad added the ci:skip Skip all CI builds/tests for this PR label Oct 12, 2026

amd-bfilipov approved these changes Oct 15, 2026

View reviewed changes

lumachad force-pushed the users/arikalo/rocdbgapi/unit_feature_tests branch from 995db06 to 6d23843 Compare October 28, 2026 10:32

lumachad removed the ci:skip Skip all CI builds/tests for this PR label Oct 28, 2026

lumachad merged commit f9a7ae7 into develop Oct 28, 2026
80 of 84 checks passed

lumachad deleted the users/arikalo/rocdbgapi/unit_feature_tests branch October 28, 2026 11:15

pmoutsias-amd mentioned this pull request Nov 3, 2026

Move ROCdbgapi changelog entries for code merged after the ROCm 10.2.0 branch to the rocm-dbgapi-0.84.0 for ROCm-X section #14933

Open

Conversation

motokultivator commented Sep 24, 2026 • edited by lumachad Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

therock-pr-bot Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Policy Checks Passed

Uh oh!

therock-pr-bot Bot commented Sep 24, 2026

Uh oh!

lumachad commented Sep 28, 2026

Uh oh!

lumachad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lumachad commented Oct 1, 2026

Uh oh!

lumachad commented Oct 6, 2026

Uh oh!

motokultivator commented Oct 6, 2026

Uh oh!

lumachad commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lumachad commented Oct 7, 2026

Uh oh!

motokultivator commented Oct 8, 2026

Uh oh!

lumachad commented Oct 12, 2026

Uh oh!

amd-bfilipov left a comment

Choose a reason for hiding this comment

Uh oh!

lumachad commented Oct 19, 2026

Uh oh!

Uh oh!

lumachad commented Oct 28, 2026

Uh oh!

systems-assistant Bot commented Oct 29, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

motokultivator commented Sep 24, 2026 •

edited by lumachad

Loading

therock-pr-bot Bot commented Sep 24, 2026 •

edited

Loading

lumachad commented Oct 6, 2026 •

edited

Loading