Repository navigation
[rocjitsu] Reuse VM snapshots across dispatch execution - #12147
Merged
newling merged 5 commits intoOct 7, 2026
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
force-pushed
the
users/jnewling/rocjitsu-dispatch-vm-snapshot
branch
from
September 23, 2026 22:00
5f3f9ab to
982e364
Compare
newling
marked this pull request as ready for review
September 23, 2026 22:26
kuhar
reviewed
Sep 24, 2026
newling
force-pushed
the
users/jnewling/rocjitsu-dispatch-vm-snapshot
branch
from
September 24, 2026 18:46
982e364 to
58fca88
Compare
newling
force-pushed
the
users/jnewling/rocjitsu-dispatch-vm-snapshot
branch
4 times, most recently
from
September 30, 2026 18:38
4565e3b to
3551782
Compare
newling
force-pushed
the
users/jnewling/rocjitsu-dispatch-vm-snapshot
branch
2 times, most recently
from
October 5, 2026 18:14
0ed97a5 to
68579f5
Compare
Discard uncommitted AQL wave setup and schedule a retry when kernarg preload or scratch validation observes revocation. No guest code has executed and scratch provisioning is idempotent, so setup can recover without publishing a terminal queue fault. Cover both paths with controls, successful completion, and a two-wave workgroup that must reclaim its reservations.
newling
force-pushed
the
users/jnewling/rocjitsu-dispatch-vm-snapshot
branch
from
October 6, 2026 21:01
68579f5 to
8a11a3d
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
anujshuk-amd
pushed a commit
that referenced
this pull request
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12217 already caches instruction-fetch VM snapshots per CU. This PR extends reuse to data operations, kernarg preloads, and scratch validation, avoiding their repeated global-registry acquisitions. Waves share the snapshot captured during AQL admission; the per-CU instruction cache remains the fallback.
Waves retain the admission root across VM-root replacement; changes within that root remain visible. Invalidation, unregister, and reset revoke access. Fetch and uncommitted wave setup retry with fresh access when available. Revoked in-flight data operations abort the dispatch and report a runtime memory-violation exception without successful completion, since replay could repeat partial effects. The deferred-load regression also reproduces develop’s missing completion/exception and verifies the PR’s failure notification.
A hipBLASLt comparison used 20 measured process runs per revision, plus two excluded warmups each, executing the same first 100 solutions of the 513 × 513 × 513
sk_sgemm_quickgroupCijk_Ailk_Bjlk_S_B_UserArgs_01. The PR used less wall time in all 20 pairs: 9.7% lower paired geometric mean wall time, with a 95% paired-bootstrap interval of 7.2–12.6%. All 4,000 measured solution validations passed. This is one workload on a shared host, with substantial timing variation.All 20 paired process wall times
Measured develop
9219e7f966against PRef5b637212, before the setup-recovery follow-up. Identical artifacts/configuration, Clang 23 Release builds, six-CPU emulator budget, andOMP_NUM_THREADS=1. Odd pairs ran develop first; even pairs ran the PR first. Every measured run is included. The bootstrap resamples these 20 pairs and describes variability within this experiment.Focused Release/ThreadSanitizer tests, GCC UBSan compilation, and changed-file pre-commit checks pass, including controls for successful setup recovery and runtime-visible data-access failure.
Motivated by hipBLASLt emulation timeouts in ROCm/rocm-libraries#10534.
JIRA ID: AIHPBLAS-3988