Repository navigation
fix(clr): feature identifying in query_shared_rank coop groups function - #12099
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
idubinov
changed the title
Contributor
Author
|
@AlexVlx , please correct me if I missed something |
aobolensk
approved these changes
Sep 23, 2026
aobolensk
left a comment
aobolensk
left a comment
Contributor
There was a problem hiding this comment.
I'd scan if it is really one and only case
Contributor
Author
did it of course, claude's agents have not found anything with the same pattern |
Contributor
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
AlexXAmd
approved these changes
Oct 5, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The early exit pattern is not supported; the only limited code patterns are supported for feature identifying; it was discussed in llvm/llvm-project#134016.
In this PR the early exit
if (!inv) trap; do;was replaced withif (inv) { do; } trap;statement.Technical Details
In this PR the early exit
if (!inv) trap; do;was replaced withif (inv) { do; } trap;statement.Issue Tracking
JIRA ID
ROCM-30737
Test Plan
No unit tests expected for this changes
Test Result
No tests changd
Submission Checklist