[amd-jiali]

Motivation

• The NCCL v2.31.2-1 sync (b71e057a71c) added GdrFlushTest.ForcedScratchpadWrite_ReproducesFault under ENABLE_FAULT_INJECTION. That case calls gdrSupported() and RunRecvFlushBurst(..., /*forceWrite=*/true, &forced). There is no gdrSupported symbol, and RunRecvFlushBurst takes three arguments. FAULT_INJECTION defaults to ON, so rccl-UnitTestsMPI fails to compile. The nightly then reports return code 183 because OpenMPI cannot start the missing binary. The coco PR arm does not build this target, so the break only shows up in oci-rccl-unit-nightly.

• #10450 wrapped the case in #if 0. The calls were still the merge-introduced ones, and the case cannot be restored without a forceWrite hook that was never added.

Technical Details

Remove ForcedScratchpadWrite_ReproducesFault from projects/rccl/test/transport/NetIbMPI/GdrFlushTests.cpp. It was not in the tree before the sync. The other GDR flush cases keep the three-argument RunRecvFlushBurst and gdrPtrSupport().

Issue Tracking

JIRA ID: AICOMRCCL-2403

Test Plan

• On a compute node with ROCm 7.14.0, from a tree that contains b71e057a71c, rebuild rccl-UnitTestsMPI with ENABLE_MPI_TESTS=ON and FAULT_INJECTION=ON.

• Confirm GdrFlushTests.cpp compiles, the binary is produced, and ForcedScratchpadWrite is not linked.

Test Result

The debug cache had FAULT_INJECTION=ON and ENABLE_MPI_TESTS=ON.

GdrFlushTests.cpp compiled and rccl-UnitTestsMPI linked.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/rccl/test/transport/NetIbMPI/GdrFlushTests.cpp; no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[amd-argus]

ARGUS

Bottom line: LGTM once the comment at GdrFlushTests.cpp:221 drops the "removed" framing for the scratchpad RDMA_WRITE. That one is a wording fix, so it does not need another pass from me.

_{Comment @argus review to re-run, or @argus re-review after pushing.}

[weilewei]

seems reasonable to me

[amd-argus]

ARGUS

Bottom line: LGTM once the comment at GdrFlushTests.cpp:220-225 is collapsed onto the suggested two lines: the round-1 one-liner was appended rather than substituted, so line 224 breaks off mid-sentence. That is a comment fix, so it does not need another pass from me.

_{Comment @argus review to re-run, or @argus re-review after pushing.}

[systems-assistant]

TheRock Submodule Bump Activity

Newest first

• 2026-10-05 — Included in TheRock via ROCm/TheRock#8732.