Repository navigation
chore(rdc): open ROCm 10.1.0 changelog and bump version to 1.4.0 - #11722
Merged
Merged
Conversation
RDC's CHANGELOG never advanced past 7.14.0 while sibling projects (amdsmi, rocm-smi-lib, rocprofiler-sdk) moved to 10.0.0/10.1.0 after the ROCm release line was renumbered (10.1.0 opened Aug 22). Open the 10.1.0 section and move the three entries that merged after the cutover out of the stale 7.14.0 section: - Removed: unused GetBlockNameStr() test helper - Resolved: RDC_FI_GPU_MEMORY_CUR_BANDWIDTH zero-under-DMA fix - Resolved: RDC_FI_ECC_*_TOTAL hang when GPU blocks exceed bit 31 Bump the package version 1.3.1 -> 1.4.0 to match, mirroring the amdsmi "open next changelog + bump version" chore. Signed-off-by: Adam360x <Adam.pryor@amd.com>
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Align hard-coded runtime versions with 1.4.0 and correct the changelog issue reference.
Pull request overview
Opens the RDC 1.4.0 changelog for ROCm 10.1.0 and updates the package version.
Changes:
- Adds the 1.4.0 changelog section and relocates post-cutover entries.
- Bumps the CMake package version from 1.3.1 to 1.4.0.
File summaries
| File | Summary |
|---|---|
projects/rdc/CHANGELOG.md |
Adds the new release section and moves relevant entries; the helper removal entry should reference #10973. |
projects/rdc/CMakeLists.txt |
Bumps the package version to 1.4.0; runtime-reported versions remain inconsistent. |
Review details
Suppressed comments (2)
projects/rdc/CHANGELOG.md:9
- This entry still cites #10949, which is the tracking issue for the build failure, while the PR description identifies #10973 as the merged change that removed
GetBlockNameStr(). Please use #10973 here so the new 10.1.0 entry points to the change being moved and matches the stated changelog audit.
- Removed the unused `GetBlockNameStr()` test helper and its GPU block name map. Nothing called it, and its `static_assert` on `AMDSMI_GPU_BLOCK_LAST` broke the RDC build whenever AMD SMI added an IP block (#10949).
projects/rdc/CMakeLists.txt:99
- This bumps the CPack/project version to 1.4.0, but the user-visible versions remain hard-coded as 1.3.0 in
rdci/src/rdci.cc:43-45andserver/include/rdc/rdc_server_main.h:33-35. A package built from this tree would therefore identify itself as RDC 1.4.0 whilerdci --versionand RDCD's version response report 1.3.0; update or derive those values as part of the release bump.
get_version_from_tag("1.4.0" ${PKG_VERSION_GIT_TAG_PREFIX} GIT)
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmitrii-galantsev
approved these changes
Sep 16, 2026
marifamd
approved these changes
Sep 16, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
marifamd
pushed a commit
that referenced
this pull request
Oct 27, 2026
## Motivation A release notes review found that the RDC changelog on develop mixes RDC 1.4.0 entries, which ship in ROCm 10.2.0, with entries that already shipped in ROCm 10.1.0 as RDC 1.3.1. #11722 opened the 1.4.0 section as "for ROCm 10.1.0" after ROCm 10.1 had branched, so later RDC entries landed under the wrong release. ## Technical Details - Retitle `## RDC 1.4.0 for ROCm 10.1.0` to `## RDC 1.4.0 for ROCm 10.2.0`. - Add `## RDC 1.3.1 for ROCm 10.1.0` with the two entries from #10973, which ROCm 10.1.0 contains: - Removed: the unused `GetBlockNameStr()` test helper. - Resolved: the `RDC_FI_ECC_*_TOTAL` hang on GPU blocks above bit 31. - Keep the `RDC_FI_GPU_MEMORY_CUR_BANDWIDTH` fix (#11634) under 1.4.0 as a one-line entry that says the fix is now included. #11634 merged on 2026-09-15, after the ROCm 10.1 branch point (2026-09-08), and ROCm 10.1.0 does not contain it. The published ROCm 10.1.0 release notes already list this fix and can't be changed, so the 1.4.0 entry doesn't repeat the full description. - The two #10973 entries move unchanged. No other files change. Evidence: - TheRock tag `therock-10.1` pins rocm-systems `7da43026e4f`, which is also the rocm-systems `therock-10.1` tag and the head of `release/therock-10.1`. Its RDC version is 1.3.1. - `721f051b86c` (#10973) is an ancestor of `7da43026e4f`. `fc654c7c9db` (#11634) is not. Both are in `release/bkc/therock-10.2-20261013`. - The released ROCm 10.1.0 packages match. `amdrocm-amdsmi10.1` 10.1.0-3 reports version `27.1.0+7da43026`. The `librdc.so` in `amdrocm-rdc10.1` 10.1.0-3 does not contain `derive_mem_activity_percent()`, the function #11634 added. The 10.2 nightly from 2026-10-21 does. ## Issue Tracking No JIRA ticket. Reported in a release notes review. ## Test Plan Changelog-only change. A script moved the #10973 entries byte for byte and checked that the only added or removed non-blank lines are section headings. A second script replaced the #11634 entry by exact match and checked that it stays in the 1.4.0 section. --------- Signed-off-by: Adam360x <Adam.pryor@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RDC's
CHANGELOG.mdnever advanced past## RDC 1.3.1 for ROCm 7.14.0, while the sibling telemetry projects (amdsmi, rocm-smi-lib, rocprofiler-sdk) all opened10.0.0/10.1.0sections after the ROCm release line was renumbered (7.14 -> 10.0 -> 10.1; amdsmi opened10.1.0on Aug 22 in #10391). As a result, changelog entries for RDC changes that merged after the cutover were being appended to the stale7.14.0section, and the package version stayed frozen at1.3.1.This mirrors the amdsmi "open next changelog + bump version" chore.
Technical Details
## RDC 1.4.0 for ROCm 10.1.0section.7.14.0and into10.1.0:GetBlockNameStr()test helper (feat(amdsmi): reland gpu_block_t expansion with rdc build fix #10973, Sep 1)RDC_FI_GPU_MEMORY_CUR_BANDWIDTHzero-under-DMA fix (fix(rdc): report current memory bandwidth under DMA traffic #11634, Sep 15)RDC_FI_ECC_*_TOTALhang on GPU blocks above bit 31 (feat(amdsmi): reland gpu_block_t expansion with rdc build fix #10973, Sep 1)1.3.1 -> 1.4.0inCMakeLists.txt.Test Plan
Changelog + version-default change; no runtime behavior change. pre-commit hooks pass (codespell, gersemi, trailing-whitespace, end-of-file-fixer). Markdown is excluded from pre-commit, and the CMake change is an in-place default-version string swap that does not affect gersemi formatting.
No JIRA ticket for this changelog/version chore.