Repository navigation
test(rccl): Validate gin not connected path in ncclCommGetAsyncError - #11652
Merged
Merged
Conversation
Kapil-Shyam-Pawar
requested review from
a team
and
a lite review from Copilot
September 15, 2026 16:59
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused regression test passes and covers the intended behavior.
Pull request overview
Adds a regression microtest for ncclCommGetAsyncError when GIN is selected but not connected.
Changes:
- Covers a non-null, disconnected GIN state.
- Verifies the call returns
ncclSuccesswithout querying GIN errors.
File summaries
| File | Description |
|---|---|
projects/rccl/test/host/init-test.cc |
Adds coverage for the disconnected GIN path. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alex-breslow-amd
approved these changes
Sep 15, 2026
alex-breslow-amd
left a comment
alex-breslow-amd
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for increasing our test coverage.
mch
approved these changes
Sep 15, 2026
garzaran
approved these changes
Sep 15, 2026
![amd-argus[bot]](https://avatars.githubusercontent.com/in/4740020?s=60&v=4){kind=small}
Kapil-Shyam-Pawar
force-pushed
the
users/kpawar/gin-comm
branch
from
September 16, 2026 05:51
fabd75c to
9c329ed
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 14, 2026
…11652) ## Motivation NCCL 2.29.7-1 ([56a0c22](NVIDIA/nccl@56a0c22), [issue #2019](NVIDIA/nccl#2019)) fixed `ncclCommGetAsyncError` to guard its GIN checks on `ginState.connected` instead of `ginState.ncclGin`, so a GIN backend that was selected but never connected no longer gets its error state polled RCCL picked this up in [#6674](#6674) (Sync v2.29.7-1), but no test covered that branch. ## Technical Details Added `InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery` to `test/host/init-test.cc`: a comm with `ginState.ncclGin` non-null but `connected = false` and the GIN fake reporting an error must still return `ncclSuccess`, proving the guard short-circuits before `ncclGinQueryLastError` runs. ## Issue Tracking JIRA ID: AICOMRCCL-1890 ## Test Plan Build & Run: ``` bash install.sh -l -t -d --debug cd build/debug/test/host ./rccl-UnitTestsMicroInit --gtest_filter='InitMicrotest.GetAsyncError*' ``` ## Test Result All 9 `GetAsyncError` microtests pass, including the new one ``` [ RUN ] InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery [ OK ] InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery (0 ms) [ PASSED ] 9 tests. ``` The existing `GetAsyncError_GinError_ReturnsRemoteError` logs GIN Error detected from `init.cc` The new test logs nothing, confirming the GIN block was skipped rather than entered and passed through. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 15, 2026
…11652) ## Motivation NCCL 2.29.7-1 ([56a0c22](NVIDIA/nccl@56a0c22), [issue #2019](NVIDIA/nccl#2019)) fixed `ncclCommGetAsyncError` to guard its GIN checks on `ginState.connected` instead of `ginState.ncclGin`, so a GIN backend that was selected but never connected no longer gets its error state polled RCCL picked this up in [#6674](#6674) (Sync v2.29.7-1), but no test covered that branch. ## Technical Details Added `InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery` to `test/host/init-test.cc`: a comm with `ginState.ncclGin` non-null but `connected = false` and the GIN fake reporting an error must still return `ncclSuccess`, proving the guard short-circuits before `ncclGinQueryLastError` runs. ## Issue Tracking JIRA ID: AICOMRCCL-1890 ## Test Plan Build & Run: ``` bash install.sh -l -t -d --debug cd build/debug/test/host ./rccl-UnitTestsMicroInit --gtest_filter='InitMicrotest.GetAsyncError*' ``` ## Test Result All 9 `GetAsyncError` microtests pass, including the new one ``` [ RUN ] InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery [ OK ] InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery (0 ms) [ PASSED ] 9 tests. ``` The existing `GetAsyncError_GinError_ReturnsRemoteError` logs GIN Error detected from `init.cc` The new test logs nothing, confirming the GIN block was skipped rather than entered and passed through. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 15, 2026
…11652) ## Motivation NCCL 2.29.7-1 ([56a0c22](NVIDIA/nccl@56a0c22), [issue #2019](NVIDIA/nccl#2019)) fixed `ncclCommGetAsyncError` to guard its GIN checks on `ginState.connected` instead of `ginState.ncclGin`, so a GIN backend that was selected but never connected no longer gets its error state polled RCCL picked this up in [#6674](#6674) (Sync v2.29.7-1), but no test covered that branch. ## Technical Details Added `InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery` to `test/host/init-test.cc`: a comm with `ginState.ncclGin` non-null but `connected = false` and the GIN fake reporting an error must still return `ncclSuccess`, proving the guard short-circuits before `ncclGinQueryLastError` runs. ## Issue Tracking JIRA ID: AICOMRCCL-1890 ## Test Plan Build & Run: ``` bash install.sh -l -t -d --debug cd build/debug/test/host ./rccl-UnitTestsMicroInit --gtest_filter='InitMicrotest.GetAsyncError*' ``` ## Test Result All 9 `GetAsyncError` microtests pass, including the new one ``` [ RUN ] InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery [ OK ] InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuery (0 ms) [ PASSED ] 9 tests. ``` The existing `GetAsyncError_GinError_ReturnsRemoteError` logs GIN Error detected from `init.cc` The new test logs nothing, confirming the GIN block was skipped rather than entered and passed through. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NCCL 2.29.7-1 (56a0c22, issue #2019) fixed
ncclCommGetAsyncErrorto guard its GIN checks onginState.connectedinstead ofginState.ncclGin, so a GIN backend that was selected but never connected no longer gets its error state polledRCCL picked this up in #6674 (Sync v2.29.7-1), but no test covered that branch.
Technical Details
Added
InitMicrotest.GetAsyncError_GinNotConnected_SkipsTheGinQuerytotest/host/init-test.cc: a comm withginState.ncclGinnon-null butconnected = falseand the GIN fake reporting an error must still returnncclSuccess, proving the guard short-circuits beforencclGinQueryLastErrorruns.Issue Tracking
JIRA ID: AICOMRCCL-1890
Test Plan
Build & Run:
Test Result
All 9
GetAsyncErrormicrotests pass, including the new oneThe existing
GetAsyncError_GinError_ReturnsRemoteErrorlogs GIN Error detected frominit.ccThe new test logs nothing, confirming the GIN block was skipped rather than entered and passed through.
Submission Checklist