Skip to content

refactor(rocprofiler-systems): rewrite containers to be constexpr #11631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgaliffiAMD merged 4 commits into from
Sep 18, 2026
Merged

refactor(rocprofiler-systems): rewrite containers to be constexpr #11631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95bd0c0
Rewrite containers to be constexpr
mradosav-amd Sep 15, 2026
291e94c
Applied suggestions from code review
mradosav-amd Sep 17, 2026
d4a13de
fix concurent
mradosav-amd Sep 17, 2026
ba0de38
Revert "fix concurent"
mradosav-amd Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/rocprofiler-systems/source/lib/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ target_link_libraries(
rocprofiler-systems-core-library
PRIVATE rocprofiler-systems::rocprofiler-systems-interface-library
)
target_link_libraries(
rocprofiler-systems-core-library
PUBLIC rocprofiler-systems::rocprofiler-systems-containers
)
target_link_libraries(
rocprofiler-systems-core-library
PRIVATE
Expand Down
26 changes: 20 additions & 6 deletions projects/rocprofiler-systems/source/lib/core/containers/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# Copyright (c) Advanced Micro Devices, Inc.
# SPDX-License-Identifier: MIT

#
set(containers_sources)

set(containers_headers
${CMAKE_CURRENT_LIST_DIR}/aligned_static_vector.hpp
${CMAKE_CURRENT_LIST_DIR}/c_array.hpp
Expand All @@ -12,7 +9,24 @@ set(containers_headers
${CMAKE_CURRENT_LIST_DIR}/static_vector.hpp
)

target_sources(
rocprofiler-systems-core-library
PRIVATE ${containers_sources} ${containers_headers}
add_library(rocprofiler-systems-containers-library INTERFACE)
add_library(
rocprofiler-systems::rocprofiler-systems-containers
ALIAS rocprofiler-systems-containers-library
)

target_sources(rocprofiler-systems-containers-library INTERFACE ${containers_headers})

target_link_libraries(
rocprofiler-systems-containers-library
INTERFACE rocprofiler-systems::rocprofiler-systems-headers
)

target_include_directories(
rocprofiler-systems-containers-library
INTERFACE ${PROJECT_SOURCE_DIR}/source/lib
)

if(ROCPROFSYS_BUILD_TESTING)
add_subdirectory(tests)
endif()
Loading
Loading