Repository navigation
Conversation
RCCL device builds poison __hip_atomic_*; route Anvil queue/signal polling through __scoped_atomic_* with explicit memory scopes instead. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task done
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
|
Superseded by #11350. |
Contributor
Author
|
Closing without merge. This Anvil-only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__hip_atomic_*with__scoped_atomic_*helpers inanvil_device.hppso Anvil SDMA device code builds when RCCL poisons HIP atomics in device translation units.Motivation
GIN cluster CI on RCCL device builds failed with poisoned
__hip_atomic_*after the Anvil SDMA path started compiling rocSHMEM device headers. This fix is intentionally split from the AICOMRCCL-2339 signal de-alias work in #11569.Test plan
anvil_device.hpp)Made with Cursor