Skip to content

fix(rocr): fix incorrect ALLOC_MAX_SIZE reporting for HSA_HEAPTYPE_DEVICE_SVM pools #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lamikr merged 7 commits into from
Oct 29, 2026
Merged

fix(rocr): fix incorrect ALLOC_MAX_SIZE reporting for HSA_HEAPTYPE_DEVICE_SVM pools #11355

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4f386c
rocr: fix incorrect ALLOC_MAX_SIZE reporting for HSA_HEAPTYPE_DEVICE_…
prihosur-amd Sep 9, 2026
a2d4d35
fix(rocr): correct Device-SVM allocation limit comments
prihosur-amd Oct 8, 2026
5c243ed
Merge upstream/develop into users/prihosur-amd/fix-device-svm-alloc-m…
prihosur-amd Oct 8, 2026
689c6c9
Merge branch 'ROCm:develop' into users/prihosur-amd/fix-device-svm-al…
prihosur-amd Oct 8, 2026
624adb2
fix(rocr): remove redundant Device-SVM size check
prihosur-amd Oct 8, 2026
fa3fe4f
Merge branch 'ROCm:develop' into users/prihosur-amd/fix-device-svm-al…
prihosur-amd Oct 8, 2026
336134d
Merge branch 'ROCm:develop' into users/prihosur-amd/fix-device-svm-al…
prihosur-amd Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions projects/rocr-runtime/runtime/hsa-runtime/core/runtime/amd_memory_region.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@ hsa_status_t MemoryRegion::AllocateImpl(size_t& size, AllocateFlags alloc_flags,
// Skip the per-region cap on Windows/DXG so over-commit requests can
// reach WDDM; system memory still enforces the cap.
const bool is_windxg = core::Runtime::runtime_singleton_->thunkLoader()->IsWinDxg();
if (IsSystem() && (size > max_sysmem_alloc_size_)) {
const size_t max_alloc_size =
IsDeviceSVM() ? max_single_alloc_size_ : max_sysmem_alloc_size_;
if (IsSystem() && (size > max_alloc_size)) {
return HSA_STATUS_ERROR_INVALID_ALLOCATION;
}
if (!IsSystem() && !is_windxg && (size > max_single_alloc_size_)) {
Expand Down Expand Up @@ -231,9 +233,11 @@ hsa_status_t MemoryRegion::GetInfo(hsa_region_info_t attribute,
case HSA_REGION_INFO_ALLOC_MAX_SIZE:
switch (mem_props_.HeapType) {
case HSA_HEAPTYPE_SYSTEM:
case HSA_HEAPTYPE_DEVICE_SVM:
*((size_t*)value) = max_sysmem_alloc_size_;
break;
case HSA_HEAPTYPE_DEVICE_SVM:
*((size_t*)value) = max_single_alloc_size_;
break;
case HSA_HEAPTYPE_FRAME_BUFFER_PRIVATE:
case HSA_HEAPTYPE_FRAME_BUFFER_PUBLIC:
case HSA_HEAPTYPE_GPU_SCRATCH:
Expand Down
Loading