Repository navigation
Conversation
github-actions
Bot
added
the
github actions
vlaindic
force-pushed
the
users/vlaindic/always-enable-beta-pc-sampling
branch
3 times, most recently
from
October 7, 2025 08:27
5723a6d to
8c0f5f7
Compare
vlaindic
marked this pull request as draft
November 4, 2025 16:52
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Internal CI will try running all PC sampling tests. Guards for skipping tests if PC sampling is unsupported are embedded in testing suite.
vlaindic
force-pushed
the
users/vlaindic/always-enable-beta-pc-sampling
branch
from
May 15, 2026 11:17
8c0f5f7 to
9a26ea8
Compare
Member
Author
|
Still not safe to apply yet due to AILIROCR-510 and ROCM-22213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal CI will try running all PC sampling tests. Guards for skipping tests if PC sampling is unsupported are embedded in testing suite.
This PR supersedes the #1076 .
Motivation
To increase PC sampling robustness, we always enable beta PC sampling in rocprofiler's CI tests.
Technical Details
If PC sampling is unsupported, then:
Test Plan
Test Result
Submission Checklist