Repository navigation
[Do not Merge] Temporary no-op change on mirage to exercise TheRock Multi-arch CI - #11242
Closed
erman-gurses wants to merge 4 commits into
Closed
erman-gurses wants to merge 4 commits into
erman-gurses wants to merge 4 commits into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The added “temporary” comment should be made explicitly actionable (e.g., “remove before merge”) to avoid becoming stale or being accidentally merged as-is.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR introduces a deliberate no-op change in the mirage CMake wrapper to trigger/exercise TheRock multi-arch CI without altering build behavior.
Changes:
- Added a temporary comment in
emulation/mirage/CMakeLists.txtto create a no-op diff and exercise CI.
File summaries
| File | Description |
|---|---|
| emulation/mirage/CMakeLists.txt | Adds a temporary no-op comment intended to trigger TheRock multi-arch CI. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+37
to
+39
|
|
||
| # Temporary no-op change on mirage to exercise TheRock Multi-arch CI | ||
|
|
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 9, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task done
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 10, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 11, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 16, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task done
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 19, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 25, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 26, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
amd-vivekag
added a commit
to amd-vivekag/rocm-systems
that referenced
this pull request
Sep 27, 2026
`therock-pr-bot` failed on this PR after waiting out its full 900s budget: `❌ Timed out waiting for required checks to complete.` The policy itself passed. `checks.required_check_runs` in `tools/systems_pr_bot/policy.yml` has exactly one entry, `pre-commit`, and `summarize_required_checks` treats a check run that is *absent* the same as one still running, so the bot polls until it times out and returns 1. No workflow creates a check run named `pre-commit` for a change confined to `emulation/mirage/**`. The job lives in `rocjitsu-formatting.yml`, whose `paths` filter covers `emulation/rocjitsu/**` but not its sibling subtree, so the event never starts the workflow and the check run is never created. ROCm#11242, which changes only `emulation/mirage/CMakeLists.txt`, fails the bot the same way at 15m32s; ROCm#11312 touches `.github/workflows/rocjitsu-*.yml` as well, matches the filter, and passes the bot in 46s. So add `emulation/mirage/**` to the filter and `emulation/mirage` to the sparse checkout, which is what the comment above each of them asks for. Extending the existing job rather than adding a second workflow keeps one check run named `pre-commit`; two would collide in the bot's name-keyed lookup and let an arbitrary one of them decide the verdict. Verified with `pre-commit run --files` over this PR's changed files plus the workflow: the hooks that select them (trailing-whitespace, end-of-file-fixer, check-added-large-files, check-yaml) pass, and no hook rewrites a file. Out of scope and left alone: `emulation/mirage/cmake/RocjitsuCorpus.cmake` and the two files under `emulation/mirage/hotswap/cmake/` are not gersemi-clean today. The job only checks files a PR touches, so this change does not surface them here, but the next PR that edits one of them will need them formatted first. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Do not Merge] Temporary no-op change on mirage to exercise TheRock Multi-arch CI