Skip to content

test(rocjitsu): cover gfx1250 SMEM special destinations - #11197

Merged
amd-eochoalo merged 1 commit into
developfrom
users/amd-eochoalo/2026-09-03/issue-10768
Sep 3, 2026
Merged

amd-eochoalo merged 1 commit into
developfrom
users/amd-eochoalo/2026-09-03/issue-10768

Conversation

@amd-eochoalo

Copy link
Copy Markdown
Contributor

Motivation

Prevent regressions in gfx1250 SMEM handling for special scalar destinations, particularly VCC_LO, which previously could be treated as a physical SGPR selector.

Technical Details

Adds regression coverage for:

  • s_load_b32 to VCC_LO and VCC_HI
  • s_load_b64 to the VCC pair
  • SGPR, TTMP, and NULL destinations
  • VCC and TTMP address sources
  • Nonzero physical SGPR allocation bases
  • Sentinel checks ensuring special selectors do not alias physical SGPR storage

The existing architecture-aware ScalarRegisterRange writeback path required no production changes.

Issue Tracking

Closes issue #10768

Test Plan

  • Build rocjitsu_tests
  • Run focused gfx1250 SMEM and scalar-selector tests
  • Run the SMEM generator profile test
  • Run the original HIP reproducer under gfx1250_mi455x.json

Test Result

  • 11 focused tests passed
  • Generator profile test passed
  • Original reproducer passed

Submission Checklist

@amd-eochoalo
amd-eochoalo marked this pull request as ready for review September 3, 2026 17:24
@amd-eochoalo
amd-eochoalo requested review from a team and atgutier as code owners September 3, 2026 17:24
@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@sjain-stanford sjain-stanford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The focused gfx1250 SMEM regression tests pass locally; the remaining inline coverage suggestion is non-blocking.

@sjain-stanford sjain-stanford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion

@amd-eochoalo
amd-eochoalo merged commit 37b3066 into develop Sep 3, 2026
47 of 52 checks passed
@amd-eochoalo
amd-eochoalo deleted the users/amd-eochoalo/2026-09-03/issue-10768 branch September 3, 2026 19:05
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants