Repository navigation
test(rocjitsu): cover gfx1250 SMEM special destinations - #11197
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
12 tasks done
sjain-stanford
approved these changes
Sep 3, 2026
sjain-stanford
left a comment
Member
There was a problem hiding this comment.
LGTM. The focused gfx1250 SMEM regression tests pass locally; the remaining inline coverage suggestion is non-blocking.
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Prevent regressions in gfx1250 SMEM handling for special scalar destinations, particularly VCC_LO, which previously could be treated as a physical SGPR selector.
Technical Details
Adds regression coverage for:
The existing architecture-aware ScalarRegisterRange writeback path required no production changes.
Issue Tracking
Closes issue #10768
Test Plan
Test Result
Submission Checklist