Repository navigation
fix(rocshmem): fix ompi githash in dependencies - #11181
Merged
Merged
Conversation
fit the git hash used in the dependencies script after the update of the ROCm/ompi v5.0.x repo.
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward SHA pin update in a script with low blast radius and no apparent behavioral regressions introduced.
Pull request overview
Updates rocSHMEM’s dependency install script to pin Open MPI to the correct commit after the ROCm/ompi v5.0.x repository update, ensuring the script checks out the intended OMPI revision during builds.
Changes:
- Updated the pinned
_OMPI_COMMIT_HASHused byinstall_dependencies.shto the new correct git SHA.
File summaries
| File | Description |
|---|---|
| projects/rocshmem/scripts/install_dependencies.sh | Updates the pinned Open MPI commit hash used by the dependency installation workflow. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ddebonis-amd
approved these changes
Sep 3, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
systems-assistant Bot
pushed a commit
to ROCm/rocSHMEM
that referenced
this pull request
Sep 3, 2026
## Motivation fix the git hash used in the dependencies script after the update of the ROCm/ompi v5.0.x repo. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: ROCm/rocm-systems#1234 --> <!-- JIRA ID: EXAMPLECOMPONENT-1234 --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#11181 (commit 6b262e4)
Contributor
TheRock Submodule Bump ActivityNewest first
|
1 task
JeniferC99
pushed a commit
to ROCm/rocSHMEM
that referenced
this pull request
Sep 10, 2026
cherry-pick of commit ROCm/rocm-systems#11181
1 task
arjun-raj-kuppala
pushed a commit
to ROCm/rocSHMEM
that referenced
this pull request
Sep 29, 2026
cherry-pick of commit ROCm/rocm-systems#11181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix the git hash used in the dependencies script after the update of the ROCm/ompi v5.0.x repo.
Technical Details
Issue Tracking
Test Plan
Test Result
Submission Checklist