Repository navigation
ci(hipfile): change 7.2.4 CI to 7.14.0 - #11179
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
riley-dixon
reviewed
Sep 3, 2026
riley-dixon
approved these changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The updates consistently shift hipFile CI image/version selection from 7.2.4 to 7.14.0 across Dockerfiles and workflows without introducing conflicting version logic.
Pull request overview
Updates the hipFile CI container builds and GitHub Actions matrices to target ROCm 7.14.0 (replacing 7.2.4), aligning the “latest-rocm” CI images and conditional CI legs with the newer ROCm series.
Changes:
- Bumped the default
ROCM_VERSIONbuild-arg in hipFile AIS CI Dockerfiles to7.14.0(ubuntu/suse/rocky/rocky8). - Updated the hipFile image refresh workflow matrix to build/push
latest-rocm7.14.0images instead oflatest-rocm7.2.4. - Adjusted the NVIDIA build leg gate in
hipfile-ci.ymlfrom7.2.*to7.14.*, and updated a related matrix comment in the toplevel workflow.
File summaries
| File | Description |
|---|---|
| projects/hipfile/util/docker/DOCKERFILE.ais_ci_ubuntu | Updates default ROCm build arg to 7.14.0 for ubuntu CI image builds. |
| projects/hipfile/util/docker/DOCKERFILE.ais_ci_suse | Updates default ROCm build arg to 7.14.0 for suse CI image builds. |
| projects/hipfile/util/docker/DOCKERFILE.ais_ci_rocky8 | Updates default ROCm build arg to 7.14.0 for rocky8 CI image builds. |
| projects/hipfile/util/docker/DOCKERFILE.ais_ci_rocky | Updates default ROCm build arg to 7.14.0 for rocky9 CI image builds. |
| .github/workflows/hipfile-image-update.yml | Updates the image refresh matrix to publish latest-rocm7.14.0 images. |
| .github/workflows/hipfile-ci.yml | Updates NVIDIA job gating to run on ROCm 7.14.* rather than 7.2.*. |
| .github/workflows/hipfile-ci-toplevel.yml | Updates documentation comment to match the current matrix include row. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
john00003
force-pushed
the
users/john00003/hipfile-ci-7.14-10.0-fix
branch
from
September 3, 2026 16:11
c1e5976 to
0a4b01f
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to test ROCm 7.14.0
Technical Details
N/A
Issue Tracking
JIRA ID: AIHIPFILE-252
Test Plan
Run CI
Test Result
CI Passes
Submission Checklist