Repository navigation
[hipFile] Documentation updates. - #11159
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
db3dfa5 to
ea29e76
Compare
|
/docs-preview |
|
Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.) |
d690d26 to
a094aa4
Compare
|
/docs-preview |
|
Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.) |
a094aa4 to
770ad1e
Compare
|
/docs-preview |
|
Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.) |
770ad1e to
95090cf
Compare
|
/docs-preview |
|
Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.) |
There was a problem hiding this comment.
🟡 Changes recommended
The new known-issues entry is misleading about fastpath prerequisites and uses inconsistent “P2PDMA” acronym casing, which should be corrected for accurate user guidance.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates hipFile’s documentation to remove outdated “not implemented”/backend limitation warnings and to improve the generated API reference output.
Changes:
- Refresh batch API docs (header comments + reference page) to reflect current implementation status and clarify batch handle sizing limits.
- Remove outdated guidance stating async I/O can’t use fastpath, and add a new known-issue entry describing async fastpath fallback behavior.
- Update multiple API reference pages to include group members in the rendered docs (
:members:).
File summaries
| File | Description |
|---|---|
| projects/hipfile/include/hipfile.h | Updates batch API Doxygen comments (batch setup wording; removes “not implemented” warnings). |
| projects/hipfile/examples/README.md | Removes outdated note about async always using fallback path. |
| projects/hipfile/docs/tutorials/async-multistream-io.rst | Removes outdated note about async fastpath not being supported. |
| projects/hipfile/docs/troubleshooting/known-issues.rst | Adds a new known-issue describing async fastpath not retrying on fallback. |
| projects/hipfile/docs/reference/api-synchronous-io.rst | Enables :members: for the sync Doxygen group output. |
| projects/hipfile/docs/reference/api-file-and-buffer.rst | Enables :members: for the file Doxygen group output. |
| projects/hipfile/docs/reference/api-errors.rst | Enables :members: for the error Doxygen group output. |
| projects/hipfile/docs/reference/api-driver.rst | Enables :members: for the driver and core Doxygen group output. |
| projects/hipfile/docs/reference/api-batch.rst | Removes a warning block and enables :members: for the batch Doxygen group output. |
| projects/hipfile/docs/reference/api-async.rst | Removes outdated backend limitation text in the async API reference introduction. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
95090cf to
b04f95d
Compare
|
/docs-preview |
|
Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.) |
TheRock Submodule Bump ActivityNewest first
|
Motivation
Remove warnings from batch documentation.
Remove mentions of async not supporting fastpath.
Some comment fixes.
Add :members: to doxygen groups so that structs are documented.
Technical Details
Issue Tracking
JIRA ID: AIHIPFILE-232
Test Plan
Test Result
Submission Checklist