Skip to content

[hipFile] Documentation updates. - #11159

Merged
jordan-turbofish merged 5 commits into
developfrom
users/jpatters/batch-doc-update-1
Sep 3, 2026
Merged

jordan-turbofish merged 5 commits into
developfrom
users/jpatters/batch-doc-update-1

Conversation

@jordan-turbofish

@jordan-turbofish jordan-turbofish commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Remove warnings from batch documentation.
Remove mentions of async not supporting fastpath.
Some comment fixes.
Add :members: to doxygen groups so that structs are documented.

Technical Details

Issue Tracking

JIRA ID: AIHIPFILE-232

Test Plan

Test Result

Submission Checklist

@github-actions github-actions Bot added documentation Improvements or additions to documentation project: hipfile labels Sep 3, 2026
@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/hipfile/include/hipfile.h; no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@jordan-turbofish

Copy link
Copy Markdown
Contributor Author

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@jordan-turbofish jordan-turbofish changed the title [hipFile] Update documentation for batch. [hipFile] Documentation updates. Sep 3, 2026
@jordan-turbofish
jordan-turbofish force-pushed the users/jpatters/batch-doc-update-1 branch from d690d26 to a094aa4 Compare September 3, 2026 16:29
@jordan-turbofish

Copy link
Copy Markdown
Contributor Author

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@jordan-turbofish
jordan-turbofish force-pushed the users/jpatters/batch-doc-update-1 branch from a094aa4 to 770ad1e Compare September 3, 2026 16:48
@jordan-turbofish

Copy link
Copy Markdown
Contributor Author

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@jordan-turbofish
jordan-turbofish force-pushed the users/jpatters/batch-doc-update-1 branch from 770ad1e to 95090cf Compare September 3, 2026 19:21
@jordan-turbofish

Copy link
Copy Markdown
Contributor Author

/docs-preview

@jordan-turbofish
jordan-turbofish marked this pull request as ready for review September 3, 2026 19:22
Copilot AI lite review requested due to automatic review settings September 3, 2026 19:22
@jordan-turbofish
jordan-turbofish requested review from a team as code owners September 3, 2026 19:22
@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new known-issues entry is misleading about fastpath prerequisites and uses inconsistent “P2PDMA” acronym casing, which should be corrected for accurate user guidance.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates hipFile’s documentation to remove outdated “not implemented”/backend limitation warnings and to improve the generated API reference output.

Changes:

  • Refresh batch API docs (header comments + reference page) to reflect current implementation status and clarify batch handle sizing limits.
  • Remove outdated guidance stating async I/O can’t use fastpath, and add a new known-issue entry describing async fastpath fallback behavior.
  • Update multiple API reference pages to include group members in the rendered docs (:members:).
File summaries
File Description
projects/hipfile/include/hipfile.h Updates batch API Doxygen comments (batch setup wording; removes “not implemented” warnings).
projects/hipfile/examples/README.md Removes outdated note about async always using fallback path.
projects/hipfile/docs/tutorials/async-multistream-io.rst Removes outdated note about async fastpath not being supported.
projects/hipfile/docs/troubleshooting/known-issues.rst Adds a new known-issue describing async fastpath not retrying on fallback.
projects/hipfile/docs/reference/api-synchronous-io.rst Enables :members: for the sync Doxygen group output.
projects/hipfile/docs/reference/api-file-and-buffer.rst Enables :members: for the file Doxygen group output.
projects/hipfile/docs/reference/api-errors.rst Enables :members: for the error Doxygen group output.
projects/hipfile/docs/reference/api-driver.rst Enables :members: for the driver and core Doxygen group output.
projects/hipfile/docs/reference/api-batch.rst Removes a warning block and enables :members: for the batch Doxygen group output.
projects/hipfile/docs/reference/api-async.rst Removes outdated backend limitation text in the async API reference introduction.
Review details
  • Files reviewed: 10/10 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jordan-turbofish
jordan-turbofish force-pushed the users/jpatters/batch-doc-update-1 branch from 95090cf to b04f95d Compare September 3, 2026 19:29
@jordan-turbofish

Copy link
Copy Markdown
Contributor Author

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-jpatters-batch-doc-update-1/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@jordan-turbofish
jordan-turbofish merged commit bc82c8e into develop Sep 3, 2026
126 of 134 checks passed
@jordan-turbofish
jordan-turbofish deleted the users/jpatters/batch-doc-update-1 branch September 3, 2026 20:47
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants