Repository navigation
feat(hipfile) announcing lvm support and adding it to ais_check - #11154
Merged
Merged
Conversation
github-actions
Bot
added
documentation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new lvm_over_nvme logic can misclassify unreadable device-mapper topology as a definitive “not supported” result instead of “unverified,” and a few updated docs/messages need small consistency fixes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the ais-check volume scan to treat certain LVM-backed mounts as hipFile fastpath-capable (specifically LVM logical volumes whose underlying physical volumes are all local NVMe), and documents that expanded support across hipFile troubleshooting/how-to docs and changelog.
Changes:
- Add sysfs-backed device-mapper stack walking (
lvm_over_nvme) and update capability gating inais-checkto allow LVM-on-NVMe. - Extend
ais-checkunit tests to cover LVM-on-NVMe acceptance and rejection cases (mpath, scsi, unresolved topology). - Update docs and test messaging to reflect that supported LVM volumes can be fastpath-capable.
File summaries
| File | Description |
|---|---|
| projects/hipfile/tools/ais-check/tests/test_volumes.py | Adds unit tests for lvm_over_nvme and LVM-aware backing_supported/collect behavior. |
| projects/hipfile/tools/ais-check/ais-check | Implements dm_uuid_prefix, block_slaves, lvm_over_nvme, and updates backing_supported/collect logic. |
| projects/hipfile/test/common/ais-capability.h | Updates ENODEV comment wording to mention unsupported LVM volumes. |
| projects/hipfile/test/common/ais-capability.cpp | Updates ENODEV reason string to mention unsupported LVM volumes. |
| projects/hipfile/docs/troubleshooting/troubleshooting.rst | Updates example output and supported backing list to include LVM-on-NVMe. |
| projects/hipfile/docs/troubleshooting/limitations.rst | Documents LVM as an exception to “no interposing block layer” limitation. |
| projects/hipfile/docs/how-to/checking-system-compatibility.rst | Updates example table and explanation to include LVM-on-NVMe as eligible. |
| projects/hipfile/CHANGELOG.md | Announces the ais-check behavior change for LVM logical volumes. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
spolifroni-amd
suggested changes
Sep 14, 2026
spolifroni-amd
left a comment
spolifroni-amd
left a comment
Contributor
There was a problem hiding this comment.
Some changes are needed to smooth out language. Changelog entry needs to be shortened.
kurtmcmillan
approved these changes
Sep 16, 2026
akolliasAMD
force-pushed
the
users/akolliasAMD/lvmsupport
branch
from
September 16, 2026 19:52
8abf070 to
9e9dd24
Compare
spolifroni-amd
suggested changes
Sep 17, 2026
spolifroni-amd
left a comment
spolifroni-amd
left a comment
Contributor
There was a problem hiding this comment.
Minor changes to the text.
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
spolifroni-amd
approved these changes
Sep 17, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LVM volumes are supported by kfd in newer releases so it needs to be announced in the code and added to ais_check
Technical Details
checks the types of volumes
Issue Tracking
JIRA ID : AIHIPFILE-248
Test Plan
Ci has been set to work
Test Result
Submission Checklist