Skip to content

feat(rccl/gin-sdma): GIN SDMA Broadcast (-D3 hybrid Anvil-SDMA) #11142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlamd1dai merged 26 commits into from
Sep 9, 2026
Merged

feat(rccl/gin-sdma): GIN SDMA Broadcast (-D3 hybrid Anvil-SDMA) #11142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f7b1d54
rccl-tests/gin-sdma: port Broadcast -D 3 from stage3c-sdma-bcast
dlamd1dai Aug 28, 2026
88af2b8
rccl/gin-sdma: add Broadcast policy unit test and GIN CI entry
dlamd1dai Aug 28, 2026
53c72c6
rccl-tests/gin-sdma: align broadcast_perf with NCCL 2.30.7 testEngine…
dlamd1dai Aug 28, 2026
2deea58
rccl-tests/gin-sdma: add 4 GiB Broadcast GIN hybrid hang guard pytest.
dlamd1dai Aug 28, 2026
6134980
style(rccl-tests): apply black formatting to test_Broadcast.py.
dlamd1dai Aug 29, 2026
7ebc3ee
fix(rccl-tests/gin-sdma): reject negative Broadcast threshold env values
dlamd1dai Aug 31, 2026
fdb6dc6
fix(rccl-tests/gin-sdma): align Broadcast with merged AllGather conve…
dlamd1dai Sep 2, 2026
5341bbb
style(rccl-tests/gin-sdma): match merged AllGather testEngine init form
dlamd1dai Sep 2, 2026
24ced8d
fix(rccl-tests/gin-sdma): gate Broadcast RunColl case 3 on ENABLE_DEV…
dlamd1dai Sep 2, 2026
69c1150
fix(rccl-tests/gin-sdma): select Anvil-SDMA with NCCL_GIN_TYPE=6 on d…
dlamd1dai Sep 2, 2026
1758b19
style(rccl-tests/gin-sdma): escape the regex backslash in test_Broadc…
dlamd1dai Sep 2, 2026
5818938
rccl-tests/gin-sdma: make the shipped Broadcast tiling and tier order…
dlamd1dai Sep 2, 2026
37cc6e1
rccl-tests/gin-sdma: fix Broadcast per-device ring state and trim unu…
dlamd1dai Sep 2, 2026
9d2fd0c
fix(rccl-tests/gin-sdma): confine Broadcast GIN signal read and wait …
dlamd1dai Sep 2, 2026
4b553da
test(rccl-tests/gin-sdma): make Broadcast GIN pytest cases assert and…
dlamd1dai Sep 3, 2026
6a9c5e3
fix(rccl-tests/gin-sdma): gate the Broadcast ring tier on the LSA team
dlamd1dai Sep 3, 2026
18fcfc3
ci(rccl): drop the Broadcast GIN pytest smoke from the device-api job
dlamd1dai Sep 3, 2026
d111437
ci(rccl/gin): run Broadcast GIN pytest from the GIN CI job
dlamd1dai Sep 3, 2026
ee258cd
fix(rccl/gin-sdma): address Argus round-3 review findings
dlamd1dai Sep 3, 2026
109a4f6
fix(rccl/gin-sdma): SAG pytest, policy UT in GIN CI, ring acq_rel bar…
dlamd1dai Sep 3, 2026
33496fd
fix(rccl/gin-sdma): HIP MemcpyToSymbolAsync needs explicit memcpy kind
dlamd1dai Sep 3, 2026
9a70790
fix(rccl/gin-sdma): template bcastMemcpyConstantAsync for scalar symbols
dlamd1dai Sep 3, 2026
9552390
fix(rccl/gin-sdma): unshadow debug log path, correct dead threshold c…
dlamd1dai Sep 4, 2026
f2377d3
rccl-tests/gin-sdma: assert which Broadcast tier ran
dlamd1dai Sep 4, 2026
f752ebf
test(rccl-tests/gin-sdma): collect Broadcast parser guards under -k G…
dlamd1dai Sep 8, 2026
5745db9
ci(rccl/gin): keep Broadcast pytest inner budget under GIN_PYTEST_TIM…
dlamd1dai Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions projects/rccl-tests/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ set(COMMON_FILES
common.h
common.cu
gin_sdma_allgather_policy.h
gin_sdma_broadcast_policy.h
gin_sdma_devtime.h
gin_sdma_devtime_host.h
nccl1_compat.h
Expand Down Expand Up @@ -184,6 +185,16 @@ if (ENABLE_ROCSHMEM_GIN AND TARGET roc::rocshmem AND RCCL_SOURCE_DIR)
endif()
add_rccl_test(alltoallv)
add_rccl_test(broadcast)
if (ENABLE_ROCSHMEM_GIN AND TARGET roc::rocshmem)
Comment thread
dlamd1dai marked this conversation as resolved.
Resolved
# GIN-SDMA hybrid Broadcast (broadcast_perf -D 3): same device-RDC link as
# alltoall_perf/all_gather_perf so the Gin*BroadcastKernel variants resolve
# the GIN device backend (SDMA puts + LSA/LL peer stores).
target_compile_definitions(broadcast_perf PRIVATE ENABLE_ROCSHMEM_GIN)
target_compile_options(broadcast_perf PRIVATE -fgpu-rdc $<$<CONFIG:Debug>:-ggdb -O0>)
target_link_libraries(broadcast_perf PRIVATE
-Wl,--whole-archive roc::rocshmem -Wl,--no-whole-archive)
target_link_options(broadcast_perf PRIVATE -fgpu-rdc --hip-link -rdynamic)
endif()
add_rccl_test(gather)
add_rccl_test(hypercube)
add_rccl_test(reduce_scatter)
Expand Down
1,234 changes: 1,231 additions & 3 deletions projects/rccl-tests/src/broadcast.cu
View file
Open in desktop

Large diffs are not rendered by default.

361 changes: 361 additions & 0 deletions projects/rccl-tests/src/gin_sdma_broadcast_policy.h
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading