Skip to content

kfdtest: Update gfx1250 blacklist - #11051

Merged
amd-yahuil merged 2 commits into
developfrom
users/yahuil/gfx1250-blacklist
Sep 3, 2026
Merged

amd-yahuil merged 2 commits into
developfrom
users/yahuil/gfx1250-blacklist

Conversation

@amd-yahuil

@amd-yahuil amd-yahuil commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

KFDNegativeTest are working in the latest driver source and MES 0x7b for gfx1250. Take it out of blacklist.

Motivation

KFDNegativeTest.* contains two tests: BasicPipeReset and BasicSDMAReset. They are both working now.

Technical Details

KFDNegativeTest.* was temporarily blacklisted from gfx1250 due to the designed change. It was first implemented as MES detect-and-reset, but later on the design changed to MES per-queue-reset for support across ASICs using MES. After adopting the new design, KFDNegativeTest.* tests are passing.

Issue Tracking

JIRA ID: AILIKFD-20

Test Plan

run_kfdtest.sh --gtest_filter=KFDNegativeTest.*

Test Result

Tests passed

Submission Checklist

KFDNegativeTest are working in the latest driver source and MES 0x7b for
gfx1250. Take it out of blacklist.

Signed-off-by: Amber Lin <amber.lin@amd.com>
@therock-pr-bot

therock-pr-bot Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@cfreeamd cfreeamd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted pre-review (for @cfreeamd)

Reviewed projects/rocr-runtime/libhsakmt/tests/kfdtest/scripts/kfdtest.exclude. The shell continuation format is correct — KFDDBGTest.HitTrapOnWaveStartEndEvent is now properly the last entry in the gfx1250 filter block with no trailing : or \. Left one inline question about the wildcard removal.

@amd-yahuil
amd-yahuil merged commit ee05db8 into develop Sep 3, 2026
41 of 47 checks passed
@amd-yahuil
amd-yahuil deleted the users/yahuil/gfx1250-blacklist branch September 3, 2026 13:55
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants