fix(amdsmi): return SUCCESS for partial fabric data by bkanango · Pull Request #11045 · ROCm/rocm-systems

bkanango · 2026-09-01T18:12:43Z

Motivation

On systems where some fabric files (vpod_active_accels, local_accels) are legitimately empty, this caused UNEXPECTED_DATA returns instead of SUCCESS, breaking the IfoeFunctionalReadOnly.TestFabricRead test.

Technical Details

Changed the return logic to match the API contract: return SUCCESS when any files have data, NO_DATA when none do.
This will also display fabric CLI output with available data.

Also fixed typo in comment ("can read" → "cannot read").

Issue Tracking

JIRA ID: ROCM-25770

Test Plan

sudo ./amdsmitst --gtest_filter=IfoeFunctionalReadOnly.TestFabricRead

sudo amd-smi fabric

Test Result

Passed, attached logs to ticket.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

therock-pr-bot · 2026-09-01T18:13:33Z

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like `test_<name>.py` / `test_<name>.cpp` (or `<name>_test.`). Current:* code file(s) changed: `projects/amdsmi/src/amd_smi/amd_smi_gpu_device.cc`; no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

bkanango · 2026-09-04T14:15:53Z

PR #9255 merged to develop and will resolve this issue.

bkanango · 2026-09-11T12:14:19Z

Repoened the PR as Ppod Vpod PR was reverted.

On systems where some fabric files (vpod_active_accels, local_accels) are legitimately empty, this caused UNEXPECTED_DATA returns instead of SUCCESS, breaking the IfoeFunctionalReadOnly.TestFabricRead test. Changed the return logic to match the API contract: return SUCCESS when any files have data, NO_DATA when none do. This will also display fabric CLI output with available data. Also fixed typo in comment ("can read" → "cannot read"). Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>

systems-assistant · 2026-09-13T06:47:06Z

TheRock Submodule Bump Activity

Newest first

2026-09-13 — Included in TheRock via ROCm/TheRock#8175.

…11600) #11045 Source commit: `6760c671aa20be3b563ae6d4a7496e21bb5bd3a6` ## Motivation On systems where some fabric files (vpod_active_accels, local_accels) are legitimately empty, this caused UNEXPECTED_DATA returns instead of SUCCESS, breaking the IfoeFunctionalReadOnly.TestFabricRead test. ## Technical Details Changed the return logic to match the API contract: return SUCCESS when any files have data, NO_DATA when none do. This will also display fabric CLI output with available data. Also fixed typo in comment ("can read" → "cannot read"). ## Issue Tracking JIRA ID: ROCM-25770 ## Test Plan sudo ./amdsmitst --gtest_filter=IfoeFunctionalReadOnly.TestFabricRead sudo amd-smi fabric ## Test Result Passed, attached logs to ticket. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com> Co-authored-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>

## Motivation On systems where some fabric files (vpod_active_accels, local_accels) are legitimately empty, this caused UNEXPECTED_DATA returns instead of SUCCESS, breaking the IfoeFunctionalReadOnly.TestFabricRead test. ## Technical Details Changed the return logic to match the API contract: return SUCCESS when any files have data, NO_DATA when none do. This will also display fabric CLI output with available data. Also fixed typo in comment ("can read" → "cannot read"). ## Issue Tracking JIRA ID: ROCM-25770 ## Test Plan sudo ./amdsmitst --gtest_filter=IfoeFunctionalReadOnly.TestFabricRead sudo amd-smi fabric Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>

## Motivation ROCm 10.1 has branched to `release/therock-10.1`. This opens the 10.2 development cycle: it bumps the library minor version to 27.2.0 and fills the `10.2.0` changelog section. While opening it, the `10.1.0` section on `develop` was audited against the release branch, and entries that will not ship in 10.1 were moved to `10.2.0`. ## Technical Details **Version** (`include/amd_smi/amdsmi.h`, `rust-interface/src/amdsmi_wrapper.rs`): - Bump `AMDSMI_LIB_VERSION_MINOR` `1 -> 2` (27.2.0). SONAME stays `libamd_smi.so.27` (`SOVERSION` is `MAJOR` only). - Regenerate the Rust binding constant to match. The Python wrapper and Go shim carry no minor-version constant. **Changelog** (`CHANGELOG.md`): - Extend the existing `## amd_smi_lib for ROCm 10.2.0` section. - Move the `10.1.0` entries whose source PR is not on `release/therock-10.1`, and add entries for three develop-only PRs whose fixes merged without one: | Action | Source PR | Entries | |--------|-----------|---------| | Move `10.1.0` → `10.2.0` | #8624 | CLI exit-code rework: 5 Changed, 1 Removed, 2 Resolved Issues | | Move `10.1.0` → `10.2.0` | #11494 | `AMDSMI_VRAM_TYPE_HBM4` (Added) | | Move `10.1.0` → `10.2.0` | #11066 | fwupd UMA carveout (Changed) | | Move `10.1.0` → `10.2.0` | #11471 | NPM node power limit: 1 Added, 2 Changed | | Move `10.1.0` → `10.2.0` | #10678 | Version-absent `amd-smi metric` fields omitted from human output (Changed; was under Removed, but it changes output) | | Move `10.1.0` → `10.2.0` | #12144 | xGMI data counters reading as unavailable on MI450 (Resolved Issues) | | Move `10.1.0` → `10.2.0` | #12804 | NPM balancing mode get/set (Added) | | New in `10.2.0` | #11474 | Topology APIs returned uninitialized NUMA data (Resolved Issues) | | New in `10.2.0` | #11045 | `amdsmi_get_gpu_fabric_info()` rejected partial UALink sysfs data (Resolved Issues) | | New in `10.2.0` | #12999 | NULL output pointers, CPER paging after a large record, `amd-smi static --clock` traceback (3 Resolved Issues) | - Drop the `### Removed` heading left empty in `10.1.0`. - Keep the #11628 entry in `10.1.0` (cherry-picked to the release branch as #12032) and the `10.0.0` section as is (it differs from `release/therock-10.0` only by the #11046 placement fixes). **Docs** (`docs/how-to/amdsmi-cli-tool.md`): - Update the `amd-smi --help` banner and default-view header examples to 27.2.0 / ROCm 10.2.0 (stale since 27.0.0). ## Issue Tracking N/A ## Test Plan - Configure and build with `-DBUILD_TESTS=ON`; confirm CMake reports 27.2.0. - Run `pre-commit` (amdsmi config) on the changed files. - Check `10.2.0`, `10.1.0` and `10.0.0` against changelog conventions: allowed subsection headings, two-space line breaks on headline bullets, no JIRA IDs in entry text. - Diff the `10.1.0` entries and headings against `release/therock-10.1`. - No GPU run or new unit test: no runtime code changed. ## Test Result - Build: pass (`amdsmitst` links), CMake reports 27.2.0 - `pre-commit`: all hooks passed - Changelog conventions: clean for `10.2.0`, `10.1.0`, `10.0.0` - `10.1.0` vs `release/therock-10.1`: identical entries and headings --------- Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>

bkanango requested a review from a team September 1, 2026 18:12

github-actions Bot added the project: amdsmi label Sep 1, 2026

bkanango force-pushed the users/bkanango/PR-ROCM-25770 branch from b3d086a to 81a0296 Compare September 1, 2026 18:13

systems-assistant Bot added the organization: ROCm label Sep 1, 2026

marifamd approved these changes Sep 1, 2026

View reviewed changes

oliveiradan reviewed Sep 2, 2026

View reviewed changes

Comment thread projects/amdsmi/src/amd_smi/amd_smi_gpu_device.cc Resolved

bkanango closed this Sep 4, 2026

bkanango reopened this Sep 11, 2026

github-actions Bot added the MINOR ABI BREAKAGE label Sep 11, 2026

bkanango force-pushed the users/bkanango/PR-ROCM-25770 branch from 81a0296 to 57ea00b Compare September 11, 2026 12:21

github-actions Bot removed the MINOR ABI BREAKAGE label Sep 11, 2026

bkanango force-pushed the users/bkanango/PR-ROCM-25770 branch from 57ea00b to b89a314 Compare September 11, 2026 14:45

bkanango requested a review from oliveiradan September 11, 2026 14:47

oliveiradan approved these changes Sep 11, 2026

View reviewed changes

marifamd force-pushed the users/bkanango/PR-ROCM-25770 branch from b89a314 to 7b24e9b Compare September 11, 2026 16:43

marifamd merged commit 6760c67 into develop Sep 11, 2026
58 of 59 checks passed

marifamd deleted the users/bkanango/PR-ROCM-25770 branch September 11, 2026 18:43

astyrrian1 mentioned this pull request Sep 14, 2026

fix(amdsmi): return SUCCESS for partial fabric data [bkc 20260908] #11600

Merged

1 task

marifamd mentioned this pull request Oct 1, 2026

chore(amdsmi): bump version to 27.2.0 and update CHANGELOG #12623

Merged

1 task done

Navigation Menu

Repository navigation

fix(amdsmi): return SUCCESS for partial fabric data - #11045

fix(amdsmi): return SUCCESS for partial fabric data#11045
marifamd merged 1 commit into
developfrom
users/bkanango/PR-ROCM-25770

bkanango commented Sep 1, 2026

Uh oh!

therock-pr-bot Bot commented Sep 1, 2026

Uh oh!

Uh oh!

bkanango commented Sep 4, 2026

Uh oh!

bkanango commented Sep 11, 2026

Uh oh!

Uh oh!

systems-assistant Bot commented Sep 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bkanango commented Sep 1, 2026

Motivation

Technical Details

Issue Tracking

Test Plan

Test Result

Submission Checklist

Uh oh!

therock-pr-bot Bot commented Sep 1, 2026

✅ All Policy Checks Passed

Uh oh!

Uh oh!

bkanango commented Sep 4, 2026

Uh oh!

bkanango commented Sep 11, 2026

Uh oh!

Uh oh!

systems-assistant Bot commented Sep 13, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants