Repository navigation
fix(hip-tests) - Free the imported pointer to avoid mem leaks - #11023
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses memory leaks in the HIP mempool shareable-handle contract test by ensuring the device pointer returned by hipMemPoolImportPointer is freed during teardown, even on assertion failure.
Changes:
- Register a scope-exit cleanup action to
hipFree()the imported pointer created viahipMemPoolImportPointer. - Add explanatory comments clarifying the imported pool reference lifetime and why freeing the imported pointer is required.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mangupta
approved these changes
Sep 7, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Address memory leaks in the hip mempool shareable handle contract tests.
Technical Details
The imported pointer from the imported mempool using shareable handle is freed using hipFree.
Issue Tracking
JIRA ID: ROCM-30215
Test Plan
Test should not report any memory leaks when run with ASAN builds.
Test Result
No Leaks
Submission Checklist