Repository navigation
fix(amdsmi): stop the license checker policing .claude tooling - #11015
Closed
dmitrii-galantsev wants to merge 1 commit into
Closed
dmitrii-galantsev wants to merge 1 commit into
dmitrii-galantsev wants to merge 1 commit into
Conversation
check_license_headers.py is red on develop right now. Three shell scripts under projects/amdsmi/.claude/skills/ are git-tracked and in scope for the checker but never got the two-line SPDX header: .claude/skills/amdsmi-ci-logs/gh-ci-logs.sh .claude/skills/amdsmi-test-runner/run-all-tests.sh .claude/skills/amdsmi-using-git-worktrees/new-worktree.sh All three came in with #10387, which merged after #10402 added the header convention and the amdsmi-license-headers hook. The hook is pass_filenames: false and rescans the whole tree, so this fails the amdsmi LSTT Formatting leg on every amd-smi pull request, not just the one that introduced it. Header only, placed after the shebang to match tools/cmake_format.sh and cmake_modules/version_util.sh. No behavior change.
dmitrii-galantsev
requested review from
a team
and
a lite review from Copilot
September 1, 2026 01:27
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves the amdsmi-license-headers / check_license_headers.py failure on develop by adding the standard two-line AMD SPDX MIT header to the three .claude skill helper shell scripts that previously lacked it.
Changes:
- Add the two-line AMD SPDX MIT header immediately after the shebang in three skill helper scripts.
- No functional/script logic changes (header-only edit).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/amdsmi/.claude/skills/amdsmi-using-git-worktrees/new-worktree.sh | Adds AMD SPDX MIT header after shebang to satisfy license header check. |
| projects/amdsmi/.claude/skills/amdsmi-test-runner/run-all-tests.sh | Adds AMD SPDX MIT header after shebang to satisfy license header check. |
| projects/amdsmi/.claude/skills/amdsmi-ci-logs/gh-ci-logs.sh | Adds AMD SPDX MIT header after shebang to satisfy license header check. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmitrii-galantsev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
check_license_headers.pyis red ondevelop:The hook is
pass_filenames: falseand rescans the whole tree, so this fails theamdsmiLSTT Formatting leg on every amd-smi PR, not just #10387 whichintroduced the files.
Technical Details
Nothing under
.claude/is compiled, installed or distributed — it is agenttooling that happens to live in the tree. Stamping an AMD MIT header on it to
satisfy a source-header convention is the wrong fix, so exclude the directory
instead, the same way
src/ualoe_lib/already is.Three lines in
EXCLUDE_PREFIX. The skill scripts are not touched.JIRA ID
N/A. Files introduced by #10387.
Test Plan / Result
python3 projects/amdsmi/tests/check_license_headers.py— was exit 1 ondevelop, exit 0 here (whole-tree scan clean)..cwith no headerand the scan still fails on it.