Skip to content

fix(ci) add cmake prefix path rocprofiler-sdk release compatibility - #10977

Merged
venkat1361 merged 1 commit into
developfrom
users/venkat1361/fix-rel-compatibility-check
Aug 31, 2026
Merged

venkat1361 merged 1 commit into
developfrom
users/venkat1361/fix-rel-compatibility-check

Conversation

@venkat1361

@venkat1361 venkat1361 commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

https://github.com/ROCm/rocm-systems/actions/runs/33208018733/job/99555630604?pr=9584

Technical Details

Issue Tracking

Test Plan

Test Result

Submission Checklist

@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Aug 31, 2026
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@venkat1361
venkat1361 marked this pull request as ready for review August 31, 2026 16:50
@venkat1361
venkat1361 requested a review from a team as a code owner August 31, 2026 16:50
Copilot AI lite review requested due to automatic review settings August 31, 2026 16:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the rocprofiler-sdk ROCm release compatibility GitHub Actions workflow to improve CMake’s ability to locate dependencies in ROCm container images.

Changes:

  • Set CMAKE_PREFIX_PATH at the workflow level to include ROCm’s rocm_sysdeps prefix alongside /opt/rocm.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@venkat1361
venkat1361 force-pushed the users/venkat1361/fix-rel-compatibility-check branch from c4c5037 to f77101d Compare August 31, 2026 17:09
@venkat1361
venkat1361 merged commit 129ebcb into develop Aug 31, 2026
67 of 75 checks passed
@venkat1361
venkat1361 deleted the users/venkat1361/fix-rel-compatibility-check branch August 31, 2026 17:22
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants