Skip to content

fix(clr): report the full unified memory pool on large-memory APUs #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaydeeppatel1111 merged 3 commits into from
Sep 4, 2026
Merged

fix(clr): report the full unified memory pool on large-memory APUs #10974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ced0da
fix(clr): report the full unified memory pool on large-memory APUs
jaydeeppatel1111 Aug 31, 2026
c606fa0
fix(clr): zero-init offline PAL heap properties
jaydeeppatel1111 Sep 2, 2026
d1fc37b
fix(clr): address review feedback on APU memory reporting
jaydeeppatel1111 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions projects/clr/rocclr/device/pal/paldevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,14 +352,14 @@ void NullDevice::fillDeviceInfo(const Pal::DeviceProperties& palProp,
info_.globalMemSize_ = (static_cast<uint64_t>(std::min(GPU_MAX_HEAP_SIZE, 100u)) *
static_cast<uint64_t>(localRAM) / 100u);

uint uswcPercentAvailable =
((static_cast<uint64_t>(heaps[Pal::GpuHeapGartUswc].logicalSize) / Mi) > 1536 && IS_WINDOWS)
? 75
: 50;
const uint64_t gartSize = static_cast<uint64_t>(heaps[Pal::GpuHeapGartUswc].logicalSize);

// The aperture is host DRAM the GPU addresses directly, so discount it by at most
// 25%, capped at 4 GiB, rather than the 50/75% heuristic. Applies to every APU.
const uint64_t gartCredit = gartSize - std::min<uint64_t>(gartSize / 4, 4 * Gi);

if (settings().apuSystem_) {
info_.globalMemSize_ +=
(static_cast<uint64_t>(heaps[Pal::GpuHeapGartUswc].logicalSize) * uswcPercentAvailable) /
100;
info_.globalMemSize_ += gartCredit;
}

// Find the largest heap form FB memory
Expand All @@ -373,10 +373,10 @@ void NullDevice::fillDeviceInfo(const Pal::DeviceProperties& palProp,

#if IS_WINDOWS
if (settings().apuSystem_) {
info_.maxMemAllocSize_ = std::max(
(static_cast<uint64_t>(heaps[Pal::GpuHeapGartUswc].logicalSize) * uswcPercentAvailable) /
100,
info_.maxMemAllocSize_);
// One allocation is not confined to a single heap, so the ceiling is the whole pool:
// carve-out plus aperture. Measured on gfx1151 at 100 GiB across a carve-out split
// 64 GiB visible plus 32 GiB invisible.
info_.maxMemAllocSize_ = info_.globalMemSize_;
}
#endif
info_.maxMemAllocSize_ =
Expand Down
4 changes: 3 additions & 1 deletion projects/clr/rocclr/device/pal/palsettings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ bool Settings::create(const Pal::DeviceProperties& palProp,
supportDepthsRGB_ = true;
}
if (use64BitPtr_) {
maxAllocSize_ = 64ULL * Gi;
// Unified memory APUs address the carve-out and the aperture as one pool, which
// already exceeds 64 GiB on shipping parts.
maxAllocSize_ = 256ULL * Gi;
} else {
maxAllocSize_ = 3ULL * Gi;
}
Expand Down
Loading