[marifamd]

Motivation

amd-smi should report what the driver reports. The override added in #8674 masked gfx activity behind the AMDSMI_SILENCE_GFX_ACTIVITY environment variable, falling back to a gfx1250 / RLC-firmware autodetect when the variable was unset, so the tool could show N/A for a metric the driver had actually returned. This reverts that change.

It also drops a per-call getenv and a process-wide std::mutex that all four affected getters took on every invocation, which serialized concurrent multi-GPU polling in amd-smi monitor.

Technical Details

This is a straight git revert of 8da40e9 (#8674), plus one line the revert cannot cover.

Reverted verbatim:

• include/amd_smi/impl/amd_smi_utils.h, src/amd_smi/amd_smi_utils.cc — removed is_gfx_activity_silenced(), apply_gfx_activity_overrides(), the gfx1250 / RLC-firmware 0x18-0x1d detection, and its per-handle unordered_map cache guarded by a static mutex
• src/amd_smi/amd_smi.cc — amdsmi_get_gpu_metrics_info and amdsmi_get_gpu_partition_metrics_info no longer overwrite average_gfx_activity, gfx_activity_acc, or the per-XCP gfx_busy_inst / gfx_busy_acc fields; amdsmi_get_gpu_busy_percent and amdsmi_get_utilization_count no longer return AMDSMI_STATUS_NOT_SUPPORTED with an all-ones value
• py-interface/amdsmi_interface.py — the two getters no longer route their values through _validate_if_max_uint
• tests/python/unit/gpu/test_gfx_activity_silence.py — deleted

The one addition beyond the revert:

• tests/python/README.md — drops the directory listing entry for the deleted test. That line was added by a commit after feat(amdsmi): add AMDSMI_SILENCE_GFX_ACTIVITY env var to silence gfx activity #8674, so the revert leaves it pointing at a file it just deleted.

To confirm, run the revert yourself and diff it against this branch; the README line is the only difference:

git revert --no-commit 8da40e9703a   # resolve the modify/delete with: git rm

No public header signatures changed, so no wrapper regeneration is needed. No CHANGELOG entry: #8674 landed after the therock-7.14 pin, inside the unreleased 7.15.0 window, and never had one.

Issue Tracking

JIRA ID: ROCM-26000

Test Plan

• cmake .. -DBUILD_TESTS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo && make -j$(nproc)
• Hardware-free Python unit suite: python3 -m unittest discover -s unit -p "test_*.py"
• pre-commit run on every changed file
• Diffed the branch against a literal git revert of 8da40e9 on the same base
• Grepped the tree for any surviving reference to the env var, the removed functions, or the firmware constants

Test Result

• Build passes, no new warnings
• Unit suite: 42 tests, no new failures (2 pre-existing CLI-import errors also present on develop)
• pre-commit passes on all changed files, including the SPDX header hook
• Diff against the literal revert is exactly the one tests/python/README.md line
• No surviving references to the removed feature

Note for the PR bot: this is a removal-only change, so it adds no test file. The deleted test_gfx_activity_silence.py covered only the behavior being removed, and the bot's unit-test gate skips files with status removed, so the gate will flag this PR.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/amdsmi/include/amd_smi/impl/amd_smi_utils.h, projects/amdsmi/py-interface/amdsmi_interface.py, projects/amdsmi/src/amd_smi/amd_smi.cc, projects/amdsmi/src/amd_smi/amd_smi_utils.cc; no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[JeniferC99]

revert looks good to me as long as ci pass.

[systems-assistant]

TheRock Submodule Bump Activity

Newest first

• 2026-09-01 — Included in TheRock via ROCm/TheRock#7793.