Skip to content

fix(amdsmi): restore the SPDX header the topology test landed without - #10896

Closed
dmitrii-galantsev wants to merge 1 commit into
developfrom
users/dgalants/amdsmi-spdx-topology
Closed

dmitrii-galantsev wants to merge 1 commit into
developfrom
users/dgalants/amdsmi-spdx-topology

Conversation

@dmitrii-galantsev

Copy link
Copy Markdown
Contributor

Summary

develop currently fails its own amdsmi-license-headers pre-commit hook.

test_topology.py was added by #8182 (80b04cab326), which merged after the SPDX catch-up in #10402 (9b42a4ade5e), so it landed with the old 20-line MIT block. The hook is pass_filenames: false and scans the whole tree, so this single stale header turns the check red for every amd-smi PR regardless of what it touches.

Seen on #9036, #9280, #9879, #10446 and #4941 while rebasing them; in each case it was the only remaining failure.

Verification

$ python3 projects/amdsmi/tests/check_license_headers.py
$ echo $?
0

No functional change — header only.

The whole-tree license hook has no per-file scoping, so one stale header
fails pre-commit for every amd-smi contributor on develop.
@therock-pr-bot

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the repository-standard two-line SPDX MIT license header in projects/amdsmi/tests/python/unit/gpu/test_topology.py so the amdsmi-license-headers pre-commit hook passes again on develop and no longer fails unrelated PRs due to a single stale header.

Changes:

  • Replaces the legacy full MIT license block in test_topology.py with the standardized two-line SPDX header (Copyright ... + SPDX-License-Identifier: MIT).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dmitrii-galantsev

Copy link
Copy Markdown
Contributor Author

Superseded — no longer needed.

The SPDX header swap for test_topology.py landed on develop as a drive-by in #10767 (fc230e841af), which is what created the conflict here: both changes rewrite the same 20 lines.

Rebasing this branch onto current develop drops the commit outright:

dropping 42813db5884 fix(amdsmi): restore the SPDX header the topology test landed without
        -- patch contents already upstream

and the hook is green on plain develop:

$ python3 projects/amdsmi/tests/check_license_headers.py ; echo $?
0

So amdsmi-license-headers no longer fails tree-wide. Anyone rebasing #9036, #9280, #9879, #10446 or #4941 should find that check passing now without this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants