Repository navigation
fix(amdsmi): restore the SPDX header the topology test landed without - #10896
dmitrii-galantsev wants to merge 1 commit into
Conversation
The whole-tree license hook has no per-file scoping, so one stale header fails pre-commit for every amd-smi contributor on develop.
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
There was a problem hiding this comment.
Pull request overview
Restores the repository-standard two-line SPDX MIT license header in projects/amdsmi/tests/python/unit/gpu/test_topology.py so the amdsmi-license-headers pre-commit hook passes again on develop and no longer fails unrelated PRs due to a single stale header.
Changes:
- Replaces the legacy full MIT license block in
test_topology.pywith the standardized two-line SPDX header (Copyright ...+SPDX-License-Identifier: MIT).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Superseded — no longer needed. The SPDX header swap for Rebasing this branch onto current and the hook is green on plain So |
Summary
developcurrently fails its ownamdsmi-license-headerspre-commit hook.test_topology.pywas added by #8182 (80b04cab326), which merged after the SPDX catch-up in #10402 (9b42a4ade5e), so it landed with the old 20-line MIT block. The hook ispass_filenames: falseand scans the whole tree, so this single stale header turns the check red for every amd-smi PR regardless of what it touches.Seen on #9036, #9280, #9879, #10446 and #4941 while rebasing them; in each case it was the only remaining failure.
Verification
No functional change — header only.