[asasfu]

The includes for cplusplus and C were backwards, and extern C is redundant in this case, I believe.

Motivation

Fixes compilation errors or warnings for rocm_smi

Technical Details

Issue Tracking

Test Plan

Test Result

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

❌ PR Check — Action Required

Check	Status	Details
📝 PR Description	❌ Fail	Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword. Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples: • JIRA ID : TESTAUTO-6039 • JIRA ID - #330 • JIRA ID #330 • JIRA ID (on separate line) ROCM-25757 • ISSUE ID : TESTUTO-3334 • ISSUE ID #3334 • ISSUE ID - TESTAUTO-3433 • ISSUE ID (on separate line) AIRUNTIME-2352 • ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234 • Closes #10 • Fixes octo-org/octo-repo#100 • Resolves: #123 • #123 • https://github.com/<org_name>/<repo_name>/issues/123 Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/amdsmi/rocm_smi/include/rocm_smi/rocm_smi.h; no test file found
🔎 pre-commit	⏳ Pending	⏳ Still running…
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

• ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

• ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

[dmitrii-galantsev]

claude:

Correct diagnosis of a real bug — the #ifdef __cplusplus include branches were genuinely backwards and broke C consumers. Approving with b8a5620 layered on top, which restores the extern "C" { that had been dropped while its closing brace remained; the header now compiles clean as both C11 and C++17 with all rsmi_* symbols verified at C linkage.

[asasfu]

Thank you @dmitrii-galantsev I rushed this PR since I knew it was an issue but was headed away for the weekend. Thanks for validating and fixing the PR. I couldn't figure out where the matching } was for extern C {. It seemed that it might have made sense to remove it. Your changes make sense.

Glad to see you glance at this half baked PR since it was actually needed.

[dmitrii-galantsev]

yeah no prob! Whatever makes the code better! I'll take a half baked PR over an issue any day :)

we're fighting some gremlins right now, so CI might look broken. it's only partially true

[dmitrii-galantsev]

my bad meant to rebase. maybe i wont touch more PRs on friday.

[systems-assistant]

TheRock Submodule Bump Activity

Newest first

• 2026-09-01 — Included in TheRock via ROCm/TheRock#7793.