Repository navigation
feat(ci): pin TheRock workflows to b45a060 - #10748
Merged
jayhawk-commits merged 2 commits intoAug 27, 2026
Merged
jayhawk-commits merged 2 commits into
jayhawk-commits merged 2 commits into
Conversation
github-actions
Bot
added
the
github actions
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
There was a problem hiding this comment.
Pull request overview
Pins all GitHub Actions workflow checkouts and reusable-workflow references that target ROCm/TheRock to the single known-good merge commit 064a78872ba058cbbe13e96f60e05c71538e7610 (TheRock PR #7636), keeping both workflow-definition refs (uses: ...@<ref>) and runtime checkout/build ref: inputs aligned.
Changes:
- Update all
actions/checkoutsteps that pullROCm/TheRockto use commit064a78872ba058cbbe13e96f60e05c71538e7610. - Update reusable workflow calls (
uses: ROCm/TheRock/.github/workflows/...@...) and correspondingref:inputs to the same pinned commit for multi-arch CI (including nightly/ASAN variants). - Update RCCL workflow defaults (
therock_ref) to the same pinned commit.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/therock-test-packages.yml | Pins TheRock checkout (including build_tools sparse-checkout prejob) to 064a788.... |
| .github/workflows/therock-test-component.yml | Pins TheRock checkout (including build_tools sparse-checkout prejob) to 064a788.... |
| .github/workflows/therock-rccl-test-rocprof.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-rccl-test-pytorch-distributed.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-rccl-test-packages-single-node.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-rccl-test-packages-multi-node.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-rccl-test-jax-collective.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-rccl-ci-linux.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-multi-arch-ci.yml | Pins TheRock checkout + reusable workflow uses: refs + ref: inputs to 064a788.... |
| .github/workflows/therock-multi-arch-ci-nightly.yml | Pins multi-arch nightly reusable workflow uses: refs and ref: inputs to 064a788... (removes override-based ref resolution). |
| .github/workflows/therock-multi-arch-ci-asan.yml | Pins ASAN multi-arch reusable workflow uses: refs and ref: inputs to 064a788.... |
| .github/workflows/therock-multi-arch-ci-asan-nightly.yml | Pins ASAN nightly reusable workflow uses: refs and ref: inputs to 064a788.... |
| .github/workflows/therock-ci.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-ci-windows.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-ci-linux.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/therock-build-linux.yml | Pins TheRock checkout to 064a788.... |
| .github/workflows/rccl-suite.yml | Updates default therock_ref input to 064a788.... |
| .github/workflows/rccl-ci.yml | Updates default therock_ref input and fallback expressions to 064a788.... |
| .github/workflows/media-libs-ci.yml | Pins TheRock checkout to 064a788.... |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 task done
erman-gurses
approved these changes
Aug 26, 2026
jayhawk-commits
changed the title
jayhawk-commits
force-pushed
the
users/jayhawk-commits/pin-therock-multiarch-064a788
branch
from
August 27, 2026 03:52
f601f50 to
1bbb2cb
Compare
geomin12
approved these changes
Aug 27, 2026
jayhawk-commits
deleted the
users/jayhawk-commits/pin-therock-multiarch-064a788
branch
August 27, 2026 14:38
Contributor
TheRock Submodule Bump ActivityNewest first
|
amd-josnarlo
pushed a commit
that referenced
this pull request
Aug 28, 2026
Pin rocm-systems CI workflow references to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf. This keeps the reusable workflow `uses` refs and matching TheRock `ref` inputs aligned on the same known-good commit, including the multi-arch CI package toggle plumbing and the follow-up fix that skips Python package tests when Python package builds are disabled. Issue: ROCm/TheRock#3343
ScottTodd
reviewed
Aug 31, 2026
Comment on lines
52
to
+55
| with: | ||
| repository: "ROCm/TheRock" | ||
| path: "TheRock" | ||
| ref: b014dba9f285f6d510624cbe1a1d20251c99c0f4 # 2026-08-21 | ||
| ref: b45a06045cbb29c85e221748e653ac2521c6e1bf # 2026-08-26 |
Member
There was a problem hiding this comment.
This had build failures on presubmit: https://github.com/ROCm/rocm-systems/actions/runs/33037655207/job/98510172769#step:13:7786
[therock-amd-mesa] C:\274AA06C-43CF-4992-B0DC-4B5914BF6B9A\build\third-party\sysdeps\windows\amd-mesa\build\patch_source\meson.build:2206:17: ERROR: Program 'flex lex' not found or not executable
Needs a requirements change for the new component: #10951
Why was this merged?
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 8, 2026
Pin rocm-systems CI workflow references to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf. This keeps the reusable workflow `uses` refs and matching TheRock `ref` inputs aligned on the same known-good commit, including the multi-arch CI package toggle plumbing and the follow-up fix that skips Python package tests when Python package builds are disabled. Issue: ROCm/TheRock#3343
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 9, 2026
Pin rocm-systems CI workflow references to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf. This keeps the reusable workflow `uses` refs and matching TheRock `ref` inputs aligned on the same known-good commit, including the multi-arch CI package toggle plumbing and the follow-up fix that skips Python package tests when Python package builds are disabled. Issue: ROCm/TheRock#3343
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 14, 2026
Pin rocm-systems CI workflow references to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf. This keeps the reusable workflow `uses` refs and matching TheRock `ref` inputs aligned on the same known-good commit, including the multi-arch CI package toggle plumbing and the follow-up fix that skips Python package tests when Python package builds are disabled. Issue: ROCm/TheRock#3343
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 14, 2026
Pin rocm-systems CI workflow references to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf. This keeps the reusable workflow `uses` refs and matching TheRock `ref` inputs aligned on the same known-good commit, including the multi-arch CI package toggle plumbing and the follow-up fix that skips Python package tests when Python package builds are disabled. Issue: ROCm/TheRock#3343
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 15, 2026
Pin rocm-systems CI workflow references to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf. This keeps the reusable workflow `uses` refs and matching TheRock `ref` inputs aligned on the same known-good commit, including the multi-arch CI package toggle plumbing and the follow-up fix that skips Python package tests when Python package builds are disabled. Issue: ROCm/TheRock#3343
corey-derochie-amd
pushed a commit
that referenced
this pull request
Oct 15, 2026
Pin rocm-systems CI workflow references to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf. This keeps the reusable workflow `uses` refs and matching TheRock `ref` inputs aligned on the same known-good commit, including the multi-arch CI package toggle plumbing and the follow-up fix that skips Python package tests when Python package builds are disabled. Issue: ROCm/TheRock#3343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins all ROCm/TheRock workflow references used by rocm-systems CI to TheRock merge commit b45a06045cbb29c85e221748e653ac2521c6e1bf.
This keeps the reusable workflow definitions and matching TheRock
refinputs aligned on the same known-good commit, including the multi-arch CI plumbing for package build toggles and the follow-up fix that suppresses Python package tests when Python package builds are disabled.ISSUE ID : ROCm/TheRock#3343
Reference Commit: ROCm/TheRock@b45a060