Skip to content

SWDEV-552620 - Adds a new graph benchmark test for different topologies - #1073

Merged
sourabhuday merged 1 commit into
developfrom
amd/dev/sbetiger/graphTopology
Sep 25, 2025
Merged

sourabhuday merged 1 commit into
developfrom
amd/dev/sbetiger/graphTopology

Conversation

@sourabhuday

Copy link
Copy Markdown
Contributor

Motivation

This adds a new performance test with programmable number of graph nodes for different topologies
straight, parallel(all kernel nodes), mixed(memcpy and kernel nodes) and hexagon(graphs that converge)
Demonstrates several results including

  1. Graph instantiation time
  2. First Graph launch times
  3. Repeat graph launch times
  4. Graph launch + device execution

Technical Details

Test Plan

Test Result

Submission Checklist

@sourabhuday
sourabhuday marked this pull request as ready for review September 21, 2025 03:26
@sourabhuday
sourabhuday requested review from a team as code owners September 21, 2025 03:26
Copilot AI review requested due to automatic review settings September 21, 2025 03:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new performance benchmark test for HIP graphs with programmable topologies to measure graph performance across different structures. The test evaluates graph instantiation time, first launch time, repeat launch times, and end-to-end execution for various graph topologies.

Key changes:

  • Adds a standalone graph topology performance testing tool with support for straight, parallel, mixed, and hexagon topologies
  • Implements comprehensive timing measurements including CPU overhead and device execution time
  • Provides configurable parameters for graph size, repetitions, and output formats

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
hipGraphTopology.cpp New performance test implementation with topology generation and timing measurement
CMakeLists.txt Adds reference to new test file for build system

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sourabhuday
sourabhuday force-pushed the amd/dev/sbetiger/graphTopology branch 3 times, most recently from daf24e6 to 2b0ad20 Compare September 21, 2025 03:35
@sourabhuday
sourabhuday requested a review from saleelk September 21, 2025 03:36
@sourabhuday
sourabhuday force-pushed the amd/dev/sbetiger/graphTopology branch 2 times, most recently from 305bbef to ab980f9 Compare September 21, 2025 18:27

@saleelk saleelk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please chekc comments

@sourabhuday
sourabhuday force-pushed the amd/dev/sbetiger/graphTopology branch 2 times, most recently from f60a9b5 to 1e3105c Compare September 22, 2025 23:03
@sourabhuday
sourabhuday force-pushed the amd/dev/sbetiger/graphTopology branch 3 times, most recently from f886192 to 1d826dd Compare September 23, 2025 22:22
@sourabhuday
sourabhuday force-pushed the amd/dev/sbetiger/graphTopology branch from 5e6f789 to f0b28c7 Compare September 24, 2025 22:43
@sourabhuday
sourabhuday merged commit b24f922 into develop Sep 25, 2025
3 checks passed
@sourabhuday
sourabhuday deleted the amd/dev/sbetiger/graphTopology branch September 25, 2025 16:50
systems-assistant Bot pushed a commit to ROCm/hip-tests that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants