Repository navigation
SWDEV-552620 - Adds a new graph benchmark test for different topologies - #1073
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new performance benchmark test for HIP graphs with programmable topologies to measure graph performance across different structures. The test evaluates graph instantiation time, first launch time, repeat launch times, and end-to-end execution for various graph topologies.
Key changes:
- Adds a standalone graph topology performance testing tool with support for straight, parallel, mixed, and hexagon topologies
- Implements comprehensive timing measurements including CPU overhead and device execution time
- Provides configurable parameters for graph size, repetitions, and output formats
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| hipGraphTopology.cpp | New performance test implementation with topology generation and timing measurement |
| CMakeLists.txt | Adds reference to new test file for build system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sourabhuday
force-pushed
the
amd/dev/sbetiger/graphTopology
branch
3 times, most recently
from
September 21, 2025 03:35
daf24e6 to
2b0ad20
Compare
sourabhuday
force-pushed
the
amd/dev/sbetiger/graphTopology
branch
2 times, most recently
from
September 21, 2025 18:27
305bbef to
ab980f9
Compare
saleelk
reviewed
Sep 22, 2025
saleelk
reviewed
Sep 22, 2025
saleelk
reviewed
Sep 22, 2025
saleelk
reviewed
Sep 22, 2025
saleelk
reviewed
Sep 22, 2025
sourabhuday
force-pushed
the
amd/dev/sbetiger/graphTopology
branch
2 times, most recently
from
September 22, 2025 23:03
f60a9b5 to
1e3105c
Compare
saleelk
reviewed
Sep 22, 2025
sourabhuday
force-pushed
the
amd/dev/sbetiger/graphTopology
branch
3 times, most recently
from
September 23, 2025 22:22
f886192 to
1d826dd
Compare
saleelk
reviewed
Sep 24, 2025
sourabhuday
force-pushed
the
amd/dev/sbetiger/graphTopology
branch
from
September 24, 2025 22:43
5e6f789 to
f0b28c7
Compare
saleelk
approved these changes
Sep 25, 2025
systems-assistant Bot
pushed a commit
to ROCm/hip-tests
that referenced
this pull request
Sep 25, 2025
topologies (#1073) [rocm-systems] ROCm/rocm-systems#1073 (commit b24f922)
sauverma93
pushed a commit
that referenced
this pull request
Sep 26, 2025
ryang-amd
pushed a commit
that referenced
this pull request
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds a new performance test with programmable number of graph nodes for different topologies
straight, parallel(all kernel nodes), mixed(memcpy and kernel nodes) and hexagon(graphs that converge)
Demonstrates several results including
Technical Details
Test Plan
Test Result
Submission Checklist