Repository navigation
test(amdsmi): blacklist unsupported temp/frequency subtests on gfx1103 - #10695
Merged
Merged
Conversation
…3 (Hawk Point) Hawk Point (gfx1103) APUs expose the same unsupported driver metrics v3.0 read/write paths as the gfx115X (Strix Point) APUs, causing GpuFunctionalReadOnly.TempRead, GpuFunctionalReadOnly.TestFrequenciesRead and GpuFunctionalReadWrite.TestFrequenciesReadWrite to fail (driver returns UNEXPECTED_DATA instead of NOT_SUPPORTED). Add a device-specific amdsmitst blacklist for hawk_point/gfx1103 mirroring the existing gfx115X entry, and map the gfx1103 target-graphics string to it in detect_asic_filter.sh so ASIC detection selects the filter.
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends AMD SMI test filtering for Hawk Point (gfx1103) APUs by excluding known unsupported temperature and frequency subtests.
Changes:
- Adds Hawk Point and
gfx1103blacklist filters. - Maps
gfx1103detection to the device-specific filter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
projects/amdsmi/tests/amd_smi_test/detect_asic_filter.sh |
Maps gfx1103 to its filter. |
projects/amdsmi/tests/amd_smi_test/amdsmitst.exclude |
Defines Hawk Point exclusions and alias. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
marifamd
changed the title
marifamd
approved these changes
Aug 25, 2026
gabrpham
approved these changes
Aug 31, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
amdsmitstdevice-specific blacklist (added in #3210 for gfx115X / Strix Point) to cover gfx1103 / Hawk Point APUs, which reproduce the same 3-subtest failure signature.Background
gfx1103 (Hawk Point) APUs expose the same unsupported driver metrics v3.0 read/write paths as the gfx115X APUs. The driver returns
AMDSMI_STATUS_UNEXPECTED_DATA(43) instead ofNOT_SUPPORTEDfor HBM/VRAM temperatures and several clock domains, so these subtests fail:GpuFunctionalReadOnly.TempReadGpuFunctionalReadOnly.TestFrequenciesReadGpuFunctionalReadWrite.TestFrequenciesReadWriteObserved on AMD Radeon 780M, gfx1103 with a TheRock 10.1.0 build: 63 pass / 3 fail / 1 skip.
Changes
tests/amd_smi_test/amdsmitst.exclude: addFILTER[hawk_point](identical 3-test set tostrix_point) plus aFILTER[gfx1103]alias.tests/amd_smi_test/detect_asic_filter.sh: map thegfx1103target-graphics string to the new filter so ASIC detection selects it (the box'samd-smireportsgfx1103).Validation
bash -nsyntax check passes; sourcing yieldsFILTER[gfx1103]==FILTER[hawk_point]==FILTER[strix_point].gfx1103 -> GFX_TO_ASIC -> FILTERresolves to the device-specific blacklist.Notes
JIRA ID: ROCM-29359