Skip to content

hip-tests: Disable Unit_HRR_ZeroInitRoundtrip and more unit tests - #10653

Merged
amd-justchen merged 13 commits into
developfrom
users/danielbolsson/disable-hrr-zeroinit-roundtrip
Sep 1, 2026
Merged

amd-justchen merged 13 commits into
developfrom
users/danielbolsson/disable-hrr-zeroinit-roundtrip

Conversation

@danielbolsson

@danielbolsson danielbolsson commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Disable Unit_HRR_ZeroInitRoundtrip unit test an all platforms because it's currently failing on gfx1250
  • Disabling all other hrr unit tests also for now to unblock possible ci on new hw

Test plan

  • Rebuilt HrrTest for gfx950; confirmed HrrTest still builds and executes; this change disables ZeroInit case
  • Rebuild and tested that tests are skipped on at least gfx950

Tracking

JIRA ID: ROCM-30032

Disable the HRR zero-init roundtrip test via catch config so ctest
registers it as disabled across AMD and NVIDIA targets.
Keep the roundtrip enabled for gfx950 builds and disable it on other
compile-time architectures and non-AMD-Linux platforms.
@danielbolsson
danielbolsson requested a review from a team as a code owner August 24, 2026 19:39
@therock-pr-bot

therock-pr-bot Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@danielbolsson danielbolsson changed the title hip-tests: run Unit_HRR_ZeroInitRoundtrip only on gfx950 hip-tests: run Unit_HRR_ZeroInitRoundtrip Aug 25, 2026
@ROCm ROCm deleted a comment from therock-pr-bot Bot Aug 25, 2026
@danielbolsson danielbolsson changed the title hip-tests: run Unit_HRR_ZeroInitRoundtrip hip-tests: disable Unit_HRR_ZeroInitRoundtrip Aug 26, 2026
@danielbolsson danielbolsson changed the title hip-tests: disable Unit_HRR_ZeroInitRoundtrip hip-tests: Disable Unit_HRR_ZeroInitRoundtrip unit test Aug 26, 2026
@danielbolsson danielbolsson changed the title hip-tests: Disable Unit_HRR_ZeroInitRoundtrip unit test hip-tests: Disable Unit_HRR_ZeroInitRoundtrip and more unit tests Aug 28, 2026
@amd-justchen

Copy link
Copy Markdown
Contributor

Will merge given code owner approval.
The TheRock CI failures are only known infra issues, unrelated to this hip-tests change that only disables flaky unit tests in hrr.yaml:

  • Test rocgdb-gpu (xfail): known expected-fail flake
  • Test rocprofiler-sdk: known ~15-min action timeout infra flake
  • Linux MI455 Test sanity: Initialize-containers infra flake
  • therock-pr-bot: advisory bot check, not a required gate

@amd-justchen
amd-justchen merged commit 77f6c61 into develop Sep 1, 2026
68 of 77 checks passed
@amd-justchen
amd-justchen deleted the users/danielbolsson/disable-hrr-zeroinit-roundtrip branch September 1, 2026 03:24
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants