Repository navigation
feat(rccl): GIN SDMA alltoall #10386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
09af2e8
add GIN-SDMA alltoall and make librccl self-contained
Kapil-Shyam-Pawar 95bfb10
Use LSA for small and mid msg sizes
Kapil-Shyam-Pawar 7d83ed3
resolve libhsakmt by full path for rocshmem gin builds
Kapil-Shyam-Pawar 5adf6c6
Refactor and add 16B alignment check
Kapil-Shyam-Pawar 1799774
Update barriers
Kapil-Shyam-Pawar 95b1049
Scale SDMA launch block to rank count
Kapil-Shyam-Pawar b5cc999
Address review comments
Kapil-Shyam-Pawar 46bf65b
Rename SDMA thread cap and reorder eligibility checks
Kapil-Shyam-Pawar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /************************************************************************* | ||
| * Copyright (c) 2026, Advanced Micro Devices, Inc. All rights reserved. | ||
| * | ||
| * Host entry points for the GIN-SDMA all-to-all path launched from ncclAlltoAll. | ||
| * See LICENSE.txt for license information. | ||
| ************************************************************************/ | ||
|
|
||
| #ifndef GIN_ALLTOALL_H_ | ||
| #define GIN_ALLTOALL_H_ | ||
|
|
||
| #include "nccl.h" | ||
| #include "nccl_device.h" | ||
|
|
||
| struct ncclComm; | ||
|
|
||
| // Upper bound on CTAs, and so on the LSA barriers and GIN signals reserved here. | ||
| constexpr int kGinA2AMaxCtas = 64; | ||
|
|
||
| // Lazily created on the first eligible alltoall and torn down with the comm. | ||
| // Declared unconditionally, or rcclras and librccl disagree on ncclComm layout. | ||
| struct ncclGinA2AState { | ||
| bool initialized; | ||
| struct ncclDevComm devComm; | ||
| }; | ||
|
|
||
| #if defined(ENABLE_ROCSHMEM_GIN) | ||
|
|
||
| bool ncclAllToAllGinSdmaEligible(ncclComm* comm, const void* sendbuff, void* recvbuff, size_t count, | ||
| ncclDataType_t datatype); | ||
|
|
||
| ncclResult_t ncclAllToAllGinSdma(const void* sendbuff, void* recvbuff, size_t count, ncclDataType_t datatype, | ||
| ncclComm* comm, cudaStream_t stream); | ||
|
|
||
| ncclResult_t ncclGinA2AFinalize(ncclComm* comm); | ||
|
|
||
| #else | ||
|
|
||
| // gin_alltoall_sdma.cu is only compiled with the GIN backend, so teardown has | ||
| // nothing to release here. | ||
| inline ncclResult_t ncclGinA2AFinalize(ncclComm*) { return ncclSuccess; } | ||
|
|
||
| #endif | ||
|
|
||
| #endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.